Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X3: parse_rule attribute must always be of rule::attribute_type& #457

Merged
merged 1 commit into from Feb 9, 2019

Conversation

Projects
None yet
1 participant
@Kojoley
Copy link
Collaborator

commented Feb 8, 2019

After #456 parse_rule is always called with value of rule::attribute_type&
type. By removing attribute type deduction we also will turn any possible bug
in transform_attribute from a linkage to compile error.

Fixes #454

X3: parse_rule attribute must always be of rule::attribute_type&
After #456 `parse_rule` is always called with value of `rule::attribute_type&`
type. By removing attribute type deduction we also will turn any possible bug
in `transform_attribute` from a linkage to compile error.

Fixes #454

@Kojoley Kojoley merged commit d4c0179 into boostorg:develop Feb 9, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Kojoley Kojoley deleted the Kojoley:x3-fix-parse_rule-signature branch Feb 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.