Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X3: Replaced make_attribute with direct attribute construction #460

Merged
merged 1 commit into from Feb 18, 2019

Conversation

Projects
None yet
3 participants
@Kojoley
Copy link
Collaborator

commented Feb 12, 2019

If the attribute has a general way to be constructed it should already have a
default constructor.

X3: Replaced make_attribute with direct attribute construction
If the attribute has a general way to be constructed it should already have a
default constructor.
@djowel

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

These are customization points. There's a corresponding CP in Qi, again IIRC. I don't think this should be removed.

@hkaiser please correct me if I'm wrong.

@Kojoley

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 12, 2019

These are customization points.

make_attribute is not advertised as a customization point anywhere and it has a strange signature to be one of.

There's a corresponding CP in Qi

Yes there is the same thing in Qi and there are also questions about it (Karma is behaving weird IIRC, it does not pass-through attributes, something related to const problems), but I am not in the mood to touch Qi/Karma.

@djowel

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

Good point. Thoughts, @hkaiser ?

@Kojoley

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 12, 2019

If you want to know my point on Qi/Karma make_attribute - it should be merged into transform_attribute, it will solve symmetric transformation (possible, but X3 had some) problems.

@Kojoley

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 17, 2019

Ping?

@Kojoley

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 18, 2019

@hkaiser seems to be active on GitHub but does not answer here :-(

@hkaiser

This comment has been minimized.

Copy link
Collaborator

commented Feb 18, 2019

@Kojoley I don't know anything about X3, so I'd rather not say anything.

@Kojoley

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 18, 2019

@Kojoley I don't know anything about X3, so I'd rather not say anything.

There is #464 for Qi/Karma with 'backported' changes.

@Kojoley Kojoley merged commit e9b8f15 into boostorg:develop Feb 18, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Kojoley Kojoley deleted the Kojoley:x3-remove-make_attribute branch Feb 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.