Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X3: Improve situation with move only types #472

Merged

Conversation

Projects
None yet
3 participants
@Kojoley
Copy link
Collaborator

commented Feb 26, 2019

Closes #465

@djowel

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

Nice, as usual!

@Kojoley Kojoley merged commit 3253702 into boostorg:develop Feb 27, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Kojoley Kojoley deleted the Kojoley:x3-improve-situation-with-move-only-types branch Feb 27, 2019

return true;
}
};

template <typename Container, typename T>
inline bool push_back(Container& c, T&& val)
{
return push_back_container<Container>::call(c, std::move(val));
return push_back_container<Container>::call(c, static_cast<T&&>(val));

This comment has been minimized.

Copy link
@Xeverous

Xeverous Feb 27, 2019

Contributor

What's the reason behind such changes? Reducing use of standard library (compile time)?

This comment has been minimized.

Copy link
@Kojoley

Kojoley Feb 27, 2019

Author Collaborator

Removed surprising move of lvalue. And yes, std::forward is not zero cost in terms of compile time (also a surprising thing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.