Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libbacktrace fallback to sym info when debug info is missing or incomplete #60

Merged
merged 3 commits into from Aug 20, 2018

Conversation

@driesdeschout
Copy link
Contributor

commented Aug 13, 2018

This adds lookup in symbol table in case libbacktrace is fails to lookup in debug info e.g. in case it is incomplete or stripped away.

@coveralls

This comment has been minimized.

Copy link

commented Aug 13, 2018

Coverage Status

Coverage increased (+0.1%) to 93.348% when pulling 7a595a1 on driesdeschout:develop into 819f2b1 on boostorg:develop.

@coveralls

This comment has been minimized.

Copy link

commented Aug 13, 2018

Coverage Status

Coverage increased (+0.1%) to 93.318% when pulling 1289134 on DriesDeschout:develop into 819f2b1 on boostorg:develop.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

commented Aug 13, 2018

Coverage Status

Coverage increased (+0.1%) to 93.318% when pulling 1289134 on DriesDeschout:develop into 819f2b1 on boostorg:develop.

@apolukhin
Copy link
Member

left a comment

Many thanks for the PR!

@@ -90,7 +97,16 @@ struct to_string_using_backtrace {
boost::stacktrace::detail::libbacktrace_full_callback,
boost::stacktrace::detail::libbacktrace_error_callback,
&data
);
)
||

This comment has been minimized.

Copy link
@apolukhin

apolukhin Aug 17, 2018

Member

Looks like the same addition is required for the name_impl function.

@apolukhin apolukhin merged commit 745c6aa into boostorg:develop Aug 20, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@apolukhin

This comment has been minimized.

Copy link
Member

commented Aug 20, 2018

Many thanks! Great patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.