Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost_check_equal-str-test failed on llvm #177

Closed
BinCaoWR opened this Issue Nov 9, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@BinCaoWR
Copy link

BinCaoWR commented Nov 9, 2018

Test log:
../libs/test/test/writing-test-ts/boost_check_equal-str-test.cpp(55): error: in "check_string_compare": check (void*)buf_ptr_cch != (void*)buf_array_cch has failed [0x800d3fd7 == 0x800d3fd7]

Test code:
char const* buf_ptr_cch = "abc";
char const buf_array_cch[] = "abc";
BOOST_TEST((void*)buf_ptr_cch != (void*)buf_array_cch);

Potential solution:
Add “clang:off” into boost.test-self-test() from libs/test/test/Jamfile.v2 to turn off the optimization for llvm. Verified the test can pass with this solution.

@raffienficiaud

This comment has been minimized.

Copy link
Member

raffienficiaud commented Feb 4, 2019

Please check the branch topic/GH-177-boost_check_equal-str-test-failure, it should be fixed there.

@raffienficiaud raffienficiaud self-assigned this Feb 4, 2019

raffienficiaud added a commit that referenced this issue Feb 4, 2019

Merge branch 'topic/GH-177-boost_check_equal-str-test-failure' into n…
…ext-internal

* topic/GH-177-boost_check_equal-str-test-failure:
  Change log
  Preventing the compiler to optimize out the duplicate strings
@raffienficiaud

This comment has been minimized.

Copy link
Member

raffienficiaud commented Feb 8, 2019

In master, closing. Thanks!

@raffienficiaud raffienficiaud added this to the 1.70 milestone Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.