Skip to content

/ test

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random shuffle deprecated #229

Closed
NAThompson opened this issue Aug 21, 2019 · 2 comments
Closed

Random shuffle deprecated #229

NAThompson opened this issue Aug 21, 2019 · 2 comments
Assignees
@raffienficiaud
Milestone
1.72

Comments

@NAThompson
Copy link

@NAThompson NAThompson commented Aug 21, 2019

On clang 6, on this build, we have

In file included from ../../../libs/test/src/framework.cpp:16:

../../../boost/test/impl/framework.ipp:784:30: warning: 'random_shuffle<std::__1::__wrap_iter<unsigned long *>, const boost::unit_test::framework::state::random_generator_helper &>' is deprecated [-Wdeprecated-declarations]

                        std::random_shuffle( children_with_the_same_rank.begin(), children_with_the_same_rank.end(), rand_gen );

                             ^

/Applications/Xcode-11.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/algorithm:3003:1: note: 'random_shuffle<std::__1::__wrap_iter<unsigned long *>, const boost::unit_test::framework::state::random_generator_helper &>' has been explicitly marked deprecated here

_LIBCPP_DEPRECATED_IN_CXX14 void

Low priority, obviously.
@raffienficiaud raffienficiaud added this to the 1.72 milestone Oct 7, 2019
@raffienficiaud

This comment has been minimized.

Sign in to view
Copy link
Member

@raffienficiaud raffienficiaud commented Oct 7, 2019

Thanks for the report!
Removing completely the call to std::random_shuffle in favour of the drop-in (and required) replacement. Testing now.
@raffienficiaud raffienficiaud added the 1.72 label Oct 7, 2019
@raffienficiaud raffienficiaud self-assigned this Oct 15, 2019
raffienficiaud added a commit that referenced this issue Oct 20, 2019
@raffienficiaud
Merge branch 'topic/GH-229-random-shuffle-deprecation-warning' into n…
Loading status checks…
a1bafb2 
…ext-internal

* topic/GH-229-random-shuffle-deprecation-warning:
  Change log
  Removing calls to std::random_shuffle in favour of the drop-in replacement
@raffienficiaud

This comment has been minimized.

Sign in to view
Copy link
Member

@raffienficiaud raffienficiaud commented Oct 21, 2019

In master, closing.
@raffienficiaud raffienficiaud removed the 1.72 label Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raffienficiaud raffienficiaud

Labels
None yet
Projects
None yet
Milestone
  1.72
2 participants
@NAThompson @raffienficiaud
You can’t perform that action at this time.