Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Change capital variable names to lowercase #108
Conversation
|
As to obvious "why not just change VERSION to something else?" - so it's consistent. |
|
Thanks for the PR. While I understand for the |
|
Merged to branch |
|
Thanks fine too. Thank you. |
|
Merged to develop, closing. |
raffienficiaud
closed this
Feb 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
AdamMajer commentedJan 18, 2017
Capitals clash by convention with #define, and in this case
VERSION clashes with GNU Autotools. This means projecting using
GNU Autotools and Boost::Test library no longer compile.
To fix this problem and possibly others down the line,
downcase all the string constants in the rt::runtime_config
namespace. (trac 12748)