Change capital variable names to lowercase #108

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

AdamMajer commented Jan 18, 2017

Capitals clash by convention with #define, and in this case
VERSION clashes with GNU Autotools. This means projecting using
GNU Autotools and Boost::Test library no longer compile.

To fix this problem and possibly others down the line,
downcase all the string constants in the rt::runtime_config
namespace. (trac 12748)

@AdamMajer AdamMajer Change capital variable names to lowercase
Capitals clash by convention with #define, and in this case
VERSION clashes with GNU Autotools. This means projecting using
GNU Autotools and Boost::Test library no longer compile.

To fix this problem and possibly others down the line,
downcase all the string constants in the rt::runtime_config
namespace. (trac 12748)
c3f00f6
Contributor

AdamMajer commented Jan 18, 2017

As to obvious "why not just change VERSION to something else?" - so it's consistent.

Member

raffienficiaud commented Jan 30, 2017

Thanks for the PR. While I understand for the VERSION macro clash, I would like to keep this minimal. So I would rather rework your PR for fixing this issue and making those variables/macros more boost.test specific.

Member

raffienficiaud commented Jan 30, 2017

Merged to branch origin/topic/12748-VERSION-macro-clashes, thanks

Contributor

AdamMajer commented Jan 30, 2017

Thanks fine too. Thank you.

Member

raffienficiaud commented Feb 19, 2017

Merged to develop, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment