Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change capital variable names to lowercase #108

Closed
wants to merge 1 commit into from
Closed

Change capital variable names to lowercase #108

wants to merge 1 commit into from

Conversation

AdamMajer
Copy link
Contributor

Capitals clash by convention with #define, and in this case
VERSION clashes with GNU Autotools. This means projecting using
GNU Autotools and Boost::Test library no longer compile.

To fix this problem and possibly others down the line,
downcase all the string constants in the rt::runtime_config
namespace. (trac 12748)

Capitals clash by convention with #define, and in this case
VERSION clashes with GNU Autotools. This means projecting using
GNU Autotools and Boost::Test library no longer compile.

To fix this problem and possibly others down the line,
downcase all the string constants in the rt::runtime_config
namespace. (trac 12748)
@AdamMajer
Copy link
Contributor Author

As to obvious "why not just change VERSION to something else?" - so it's consistent.

@raffienficiaud
Copy link
Member

Thanks for the PR. While I understand for the VERSION macro clash, I would like to keep this minimal. So I would rather rework your PR for fixing this issue and making those variables/macros more boost.test specific.

@raffienficiaud
Copy link
Member

Merged to branch origin/topic/12748-VERSION-macro-clashes, thanks

@AdamMajer
Copy link
Contributor Author

Thanks fine too. Thank you.

@raffienficiaud
Copy link
Member

Merged to develop, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants