Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MinGW compilation problems #195

Closed
wants to merge 2 commits into
base: develop
from

Conversation

Projects
None yet
2 participants
@Lastique
Copy link
Member

Lastique commented Jan 8, 2019

This fixes problems with MinGW gcc 5.3 that were discovered in Boost.Log CI builds:

  • master_test_suite function redeclared without dllimport
  • vsnprintf not declared

The latter problem I couldn't reproduce locally, but I guess it is caused by a missing include of stdio.h. If that doesn't help, another fix might be needed.

Lastique added some commits Jan 8, 2019

Fix missing vsnprintf errors on MinGW.
vsnprintf should be declared in stdio.h, not cstdio. This commit adds the
missing include and reorganises the workarounds for different platforms that
previously included the header.
@Lastique

This comment has been minimized.

Copy link
Member Author

Lastique commented Jan 8, 2019

The dllimport problem is also fixed by #190.

@raffienficiaud

This comment has been minimized.

Copy link
Member

raffienficiaud commented Feb 3, 2019

In next

@raffienficiaud

This comment has been minimized.

Copy link
Member

raffienficiaud commented Feb 5, 2019

Merged to develop, thanks

@raffienficiaud raffienficiaud added develop and removed next labels Feb 5, 2019

@Lastique Lastique deleted the Lastique:mingw_fixes branch Feb 5, 2019

@raffienficiaud raffienficiaud added 1.70 and removed develop labels Feb 8, 2019

@raffienficiaud raffienficiaud added this to the 1.70 milestone Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.