Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commented out unused argument name (stack_decorator::apply) #219

Closed
wants to merge 1 commit into from

Conversation

@kedarbhat
Copy link
Contributor

commented Apr 21, 2019

Both GCC and Clang complain about the argument to stack_decorator::apply being unused; commenting out the variable name quiets the warning

Commented out unused argument name (stack_decorator::apply)
Both GCC and Clang complain about the argument to `stack_decorator::apply` being unused; commenting out the variable name quiets the warning
@jeking3
jeking3 approved these changes Jun 7, 2019
@jeking3

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

jking@ubuntu:~/boost/libs/dynamic_bitset/test$ bdde
docker run --cap-add=SYS_PTRACE --security-opt seccomp=unconfined -v /home/jking/boost:/boost:rw -v /home/jking/bdde:/bdde:ro -v /home/jking/.vimrc:/home/boost/.vimrc:ro --workdir /boost/libs/dynamic_bitset/test -it jeking3/bdde:linux /bin/bash
boost@e83a30c3971b:/boost/libs/dynamic_bitset/test$ b2 dyn_bitset_unit_tests1 cxxflags=-Wextra cxxflags=-pedantic
Performing configuration checks

    - default address-model    : 64-bit (cached)
    - default architecture     : x86 (cached)
    - symlinks supported       : yes (cached)
...patience...
...found 2182 targets...
...updating 4 targets...
gcc.compile.c++ ../../../bin.v2/libs/dynamic_bitset/test/dyn_bitset_unit_tests1.test/gcc-7/debug/threading-multi/visibility-hidden/dyn_bitset_unit_tests1.o
In file included from ../../../boost/test/included/unit_test.hpp:21:0,
                 from bitset_test.hpp:31,
                 from dyn_bitset_unit_tests1.cpp:18:
../../../boost/test/impl/decorator.ipp: In member function 'virtual void boost::unit_test::decorator::stack_decorator::apply(boost::unit_test::test_unit&)':
../../../boost/test/impl/decorator.ipp:114:36: warning: unused parameter 'tu' [-Wunused-parameter]
 stack_decorator::apply( test_unit& tu )
                                    ^~

@raffienficiaud raffienficiaud added the 1.71 label Jul 21, 2019

@raffienficiaud

This comment has been minimized.

Copy link
Member

commented Jul 21, 2019

Looks good, in next. Thanks!

@raffienficiaud raffienficiaud added next develop and removed next labels Jul 21, 2019

@raffienficiaud raffienficiaud added this to the 1.71 milestone Aug 3, 2019

@raffienficiaud raffienficiaud removed the develop label Aug 5, 2019

@raffienficiaud

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

It is in master now and should be part of 1.71 release, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.