Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix timeout in windows #232

Closed
wants to merge 3 commits into from
Closed

fix timeout in windows #232

wants to merge 3 commits into from

Conversation

@mmitti
Copy link
Contributor

mmitti commented Oct 24, 2019

Visual studio 2019 + Boost 1.71.0 + Windows 10 64bit

I use boost test with timeout(240) like below, it will timeout error.

BOOST_AUTO_TEST_CASE(TEST, *boost::unit_test::timeout(240)) {
    BOOST_TEST_INFO(1);
}

DueTime is 64bit, but static_cast<signed long int>(p_timeout) * 10 will 32bit and timeout value will overflow.

mmitti added 2 commits Oct 24, 2019
@raffienficiaud raffienficiaud added this to the 1.72 milestone Oct 26, 2019
@raffienficiaud raffienficiaud added the 1.72 label Oct 26, 2019
@raffienficiaud raffienficiaud self-assigned this Oct 26, 2019
@raffienficiaud

This comment has been minimized.

Copy link
Member

raffienficiaud commented Oct 31, 2019

Replaced with LONGLONG instead. Currently building in the branch topic/PR-232-fix-timeout-in-windows. Thanks!

@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 1, 2019

Codecov Report

Merging #232 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #232   +/-   ##
========================================
  Coverage    55.78%   55.78%           
========================================
  Files          112      112           
  Lines         5890     5890           
  Branches      2380     2380           
========================================
  Hits          3286     3286           
  Misses         778      778           
  Partials      1826     1826
Impacted Files Coverage Δ
include/boost/test/impl/execution_monitor.ipp 38.02% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1bafb2...d26783b. Read the comment docs.

@raffienficiaud

This comment has been minimized.

Copy link
Member

raffienficiaud commented Nov 3, 2019

Merged to master, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.