New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failures on msvc-12.0 #143

Closed
pdimov opened this Issue Sep 7, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@pdimov
Contributor

pdimov commented Sep 7, 2017

Some tests are failing on msvc-12.0, see

https://ci.appveyor.com/project/boostorg/boost/build/1.0.3620

...failed compile-c-c++ bin.v2\libs\thread\test\queue_views__single_thread_p.test\msvc-12.0\debug\threading-multi\sync\mutual_exclusion\queue_views\single_thread_pass.obj...

@viboes

This comment has been minimized.

Show comment
Hide comment
@viboes

viboes Sep 7, 2017

Collaborator

I don't know where the problem is. I've contacted Ion Gaztañaga in case he is able to see what is wrong.

Collaborator

viboes commented Sep 7, 2017

I don't know where the problem is. I've contacted Ion Gaztañaga in case he is able to see what is wrong.

@viboes

This comment has been minimized.

Show comment
Hide comment
@viboes

viboes Sep 7, 2017

Collaborator

I believe that I have an hint


        C:\projects\boost\boost/thread/csbl/devector.hpp(31) : see reference to function template instantiation 'void boost::container::vector<T,boost::container::new_allocator<T>>::push_back(const T &)' being compiled
        with
        [
            T=non_copyable
        ]

I suspect that push_back(const T &) should be defined using SFINAE :(

Collaborator

viboes commented Sep 7, 2017

I believe that I have an hint


        C:\projects\boost\boost/thread/csbl/devector.hpp(31) : see reference to function template instantiation 'void boost::container::vector<T,boost::container::new_allocator<T>>::push_back(const T &)' being compiled
        with
        [
            T=non_copyable
        ]

I suspect that push_back(const T &) should be defined using SFINAE :(

@viboes

This comment has been minimized.

Show comment
Hide comment
@viboes

viboes Sep 7, 2017

Collaborator

Wondering why do we see const T& when the code is

      template <class U>
      void priv_push_back(BOOST_FWD_REF(U) x)
      { data_.push_back(boost::forward<U>(x)); }
Collaborator

viboes commented Sep 7, 2017

Wondering why do we see const T& when the code is

      template <class U>
      void priv_push_back(BOOST_FWD_REF(U) x)
      { data_.push_back(boost::forward<U>(x)); }
@viboes

This comment has been minimized.

Show comment
Hide comment
@viboes

viboes Sep 13, 2017

Collaborator

Ion said me that he doesn't understand why the compiler is reporting this error.

I've tried to setup an appveyor CI, but I don't reach to get the results.
Once I will get the results I could create a branch trying to expand the Boost.Move macro and try to change some things in order to have a better idea.

Any help here is welcome.

For the time been I could inhibit these test while compiling on this compiler version. A PR is welcome if this behavior is desired.

Collaborator

viboes commented Sep 13, 2017

Ion said me that he doesn't understand why the compiler is reporting this error.

I've tried to setup an appveyor CI, but I don't reach to get the results.
Once I will get the results I could create a branch trying to expand the Boost.Move macro and try to change some things in order to have a better idea.

Any help here is welcome.

For the time been I could inhibit these test while compiling on this compiler version. A PR is welcome if this behavior is desired.

@viboes

This comment has been minimized.

Show comment
Hide comment
@viboes

viboes Sep 18, 2017

Collaborator

I have masked the code that makes the compilation fail.

#149

See the results here

https://ci.appveyor.com/project/viboes/thread/build/1.0.17-develop

Any comment on the PR is welcome.

Collaborator

viboes commented Sep 18, 2017

I have masked the code that makes the compilation fail.

#149

See the results here

https://ci.appveyor.com/project/viboes/thread/build/1.0.17-develop

Any comment on the PR is welcome.

@viboes viboes added the fixed label Sep 28, 2017

@viboes viboes closed this Sep 28, 2017

@viboes viboes added this to the 1.66 milestone Oct 15, 2017

@viboes viboes removed the wontfix label Apr 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment