Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed visitor result type deduction at rvalue ref operators #55

Merged
merged 2 commits into from Jan 5, 2019

Conversation

Projects
None yet
3 participants
@Kojoley
Copy link
Contributor

Kojoley commented Jan 3, 2019

No description provided.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 3, 2019

Coverage Status

Coverage remained the same at 95.063% when pulling 9af72f3 on Kojoley:fix-apply_visitor-decltype-result_type-deduction into 4addd10 on boostorg:develop.

@Kojoley

This comment has been minimized.

Copy link
Contributor Author

Kojoley commented Jan 3, 2019

It looks like I found another bug, but I do not have GCC 4.6 to investigate it. Should I blacklist it from running the test?

@apolukhin

This comment has been minimized.

Copy link
Member

apolukhin commented Jan 4, 2019

Just blacklist it along with GCC 4.7

GCC < 4.8 have wired C++11 support for rvalues. IMO it should be disabled in Boost.Config

@Kojoley Kojoley force-pushed the Kojoley:fix-apply_visitor-decltype-result_type-deduction branch from 068d8a7 to bfd51d8 Jan 5, 2019

@Kojoley Kojoley force-pushed the Kojoley:fix-apply_visitor-decltype-result_type-deduction branch from bfd51d8 to 4b37f9b Jan 5, 2019

@Kojoley

This comment has been minimized.

Copy link
Contributor Author

Kojoley commented Jan 5, 2019

I've changed macro to BOOST_NO_CXX11_REF_QUALIFIERS and it solved the issue as boost::apply_visitor calls variant type apply_visitor method which relies on ref qualifiers to detect moving.

@apolukhin apolukhin merged commit a0ad527 into boostorg:develop Jan 5, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@apolukhin

This comment has been minimized.

Copy link
Member

apolukhin commented Jan 5, 2019

Many thanks for the PR!

@apolukhin apolukhin self-assigned this Jan 5, 2019

@Kojoley Kojoley deleted the Kojoley:fix-apply_visitor-decltype-result_type-deduction branch Jan 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.