Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EDG 3.2 workaround #57

Merged
merged 2 commits into from Jan 7, 2019

Conversation

Projects
None yet
3 participants
@Kojoley
Copy link
Contributor

Kojoley commented Jan 6, 2019

EDG 3.2 is pretty old (the workaround added 16 years ago).

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 6, 2019

Coverage Status

Coverage remained the same at 95.063% when pulling 06b643d on Kojoley:remove-edg-no-sfinae into 500778b on boostorg:develop.

@apolukhin

This comment has been minimized.

Copy link
Member

apolukhin commented Jan 6, 2019

I think it should be the other way around: all the enable_if must be removed in favor of the typename Visitor::type

@Kojoley

This comment has been minimized.

Copy link
Contributor Author

Kojoley commented Jan 6, 2019

Hmm, I though it was made to allow boost::apply_visitor<Visitor const>(...).

Removed EDG 3.2 workaround
EDG 3.2 is pretty old (the workaround added 16 years ago).

@Kojoley Kojoley force-pushed the Kojoley:remove-edg-no-sfinae branch from 2c6809c to 3c5a67e Jan 6, 2019

@Kojoley Kojoley changed the title Remove EDG no SFINAE workaround Removed EDG 3.2 workaround Jan 6, 2019

@Kojoley Kojoley changed the title Removed EDG 3.2 workaround Remove EDG 3.2 workaround Jan 6, 2019


#include <boost/variant/detail/apply_visitor_unary.hpp>

#include <boost/utility/enable_if.hpp>

#if BOOST_WORKAROUND(__EDG__, BOOST_TESTED_AT(302))
#include <boost/mpl/not.hpp>

This comment has been minimized.

@apolukhin

apolukhin Jan 6, 2019

Member

Please, also drop the unnecessary headers.

#include <boost/move/utility.hpp>

#if BOOST_WORKAROUND(__EDG__, BOOST_TESTED_AT(302))
#include <boost/core/enable_if.hpp>

This comment has been minimized.

@apolukhin

apolukhin Jan 6, 2019

Member

Drop those headers too

@apolukhin apolukhin merged commit 3850c19 into boostorg:develop Jan 7, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 95.063%
Details
@apolukhin

This comment has been minimized.

Copy link
Member

apolukhin commented Jan 7, 2019

Awesome! Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.