tests: Use systemd-i128 over uuidgen #1721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`just test-composefs` fails in the new default devcontainer ref <https://github.com/bootc-dev/infra/blob/main/common/.devcontainer> without this. Signed-off-by: Colin Walters <walters@verbum.org>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces uuidgen with systemd-id128 to fix test failures in the new development container. The change is correct and addresses the issue. I've added a couple of suggestions to improve the scripts' portability by adding a fallback mechanism. This will ensure the scripts continue to work in environments that may have uuidgen but not systemd-id128, making them more robust.
Collaborator
Author
|
@gursewak1997 ping you're on first call review cycle this week, can you look through some PRs? This one is easy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just test-composefsfails in the new default devcontainer ref https://github.com/bootc-dev/infra/blob/main/common/.devcontainer without this.