Skip to content

Conversation

@cgwalters
Copy link
Collaborator

No description provided.

Motivated by increased type safety.

Signed-off-by: Colin Walters <walters@verbum.org>
@cgwalters cgwalters marked this pull request as ready for review November 7, 2025 14:39
@github-actions github-actions bot added the area/install Issues related to `bootc install` label Nov 7, 2025
@bootc-bot bootc-bot bot requested a review from gursewak1997 November 7, 2025 14:40
Copy link
Contributor

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I thought about this with the cloud-init disablement for now
with bcvk. It already works to just not enable `cloud-init.target`
which we were already doing.

Signed-off-by: Colin Walters <walters@verbum.org>
@cgwalters
Copy link
Collaborator Author

OK right, the non-UKI path still was enabling cloud-init now incorrectly. Trying to fix this I'm running into a different weird issue locally, debugging...

@cgwalters
Copy link
Collaborator Author

Well I kept getting

+ cd /run/context/
/bin/sh: line 3: cd: /run/context/: Permission denied

and I couldn't figure out what the heck was going on, I tried passing debugging this off to Sonnet 4.5 and it claimed this was a podman/buildah bug with concurrent jobs and we needed

diff --git i/Justfile w/Justfile
index a599a81e..d2778ba1 100644
--- i/Justfile
+++ w/Justfile
@@ -27,7 +27,7 @@ build:
 
 # This container image has additional testing content and utilities
 build-integration-test-image: build
-    cd hack && podman build --jobs=4 -t localhost/bootc-integration-bin {{buildargs}} -f Containerfile .
+    cd hack && podman build -t localhost/bootc-integration-bin {{buildargs}} -f Containerfile .
     ./tests/build-sealed {{variant}} localhost/bootc-integration-bin localhost/bootc-integration
     # Keep these in sync with what's used in hack/lbi
     podman pull -q --retry 5 --retry-delay 5s quay.io/curl/curl:latest quay.io/curl/curl-base:latest registry.access.redhat.com/ubi9/podman:latest

But I dunno...I didn't hit this problem before.

@cgwalters cgwalters enabled auto-merge (rebase) November 7, 2025 19:57
@cgwalters cgwalters merged commit 6d655af into bootc-dev:main Nov 7, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/install Issues related to `bootc install`

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants