Justfile: Bring back build-sealed target #1787
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reintroduces the build-sealed target in the Justfile. This change provides a convenient shorthand for building a sealed image using the composefs-sealeduki-sdboot variant, which is a good improvement for developer experience. The implementation is correct and aligns the build tooling with the project's documentation, which is a positive step. The new target is well-implemented, following good practices for recursive just calls.
cgwalters
left a comment
cgwalters
left a comment
There was a problem hiding this comment.
I think we should try hard to have all of our Justfile entrypoints have at least a single line documentation comment.
Except now this wraps the "variant" usage of `just build`. For one, this is a convenient little piece of shorthand. But perhaps more importantly, we have this referenced in the docs. Although I could go change the docs to reflect the new usage, I think it just reads nicer in the docs for it to remain `just build-sealed`. Signed-off-by: John Eckersberg <jeckersb@redhat.com>
jeckersb
force-pushed
the
bring-back-just-build-sealed-the-people-demand-it
branch
from
79514f0 to
714949a
Compare
Added. |
2 participants
Except now this wraps the "variant" usage of
just build. For one,this is a convenient little piece of shorthand. But perhaps more
importantly, we have this referenced in the docs. Although I could go
change the docs to reflect the new usage, I think it just reads nicer
in the docs for it to remain
just build-sealed.Signed-off-by: John Eckersberg jeckersb@redhat.com