Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
mm: nobootmem: fix sign extend problem in __free_pages_memory()
commit 6bc2e85 upstream.

Systems with 8 TBytes of memory or greater can hit a problem where only
the the first 8 TB of memory shows up.  This is due to "int i" being
smaller than "unsigned long start_aligned", causing the high bits to be
dropped.

The fix is to change `i' to unsigned long to match start_aligned
and end_aligned.

Thanks to Jack Steiner for assistance tracking this down.

Signed-off-by: Russ Anderson <rja@sgi.com>
Cc: Jack Steiner <steiner@sgi.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Tejun Heo <tj@kernel.org>
Cc: David S. Miller <davem@davemloft.net>
Cc: Yinghai Lu <yinghai@kernel.org>
Cc: Gavin Shan <shangw@linux.vnet.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
  • Loading branch information
Russ Anderson authored and bwhacks committed May 20, 2012
1 parent 97a2373 commit eceb337
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions mm/nobootmem.c
Expand Up @@ -83,8 +83,7 @@ void __init free_bootmem_late(unsigned long addr, unsigned long size)

static void __init __free_pages_memory(unsigned long start, unsigned long end)
{
int i;
unsigned long start_aligned, end_aligned;
unsigned long i, start_aligned, end_aligned;
int order = ilog2(BITS_PER_LONG);

start_aligned = (start + (BITS_PER_LONG - 1)) & ~(BITS_PER_LONG - 1);
Expand Down

0 comments on commit eceb337

Please sign in to comment.