Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build-toolchain.sh doesn't flag all supported options #60

Closed
vfazio opened this issue Jun 19, 2023 · 1 comment
Closed

build-toolchain.sh doesn't flag all supported options #60

vfazio opened this issue Jun 19, 2023 · 1 comment

Comments

@vfazio
Copy link
Contributor

vfazio commented Jun 19, 2023

Currently, the generated fragments that are supposed to reflect the options that are enabled are overlooking BR2_GCC_ENABLE_OPENMP, BR2_TOOLCHAIN_BUILDROOT_DLANG, and possibly others.

https://github.com/bootlin/toolchains-builder/blob/master/build-toolchain.sh#L166

quick fix:

    if grep -q "BR2_GCC_ENABLE_OPENMP=y" ${configfile}; then
        echo "BR2_TOOLCHAIN_EXTERNAL_OPENMP=y" >> ${fragment_file}
    else
        echo "# BR2_TOOLCHAIN_EXTERNAL_OPENMP is not set" >> ${fragment_file}
    fi
    if grep -q "BR2_TOOLCHAIN_BUILDROOT_DLANG=y" ${configfile}; then
        echo "BR2_TOOLCHAIN_EXTERNAL_DLANG=y" >> ${fragment_file}
    else
        echo "# BR2_TOOLCHAIN_EXTERNAL_DLANG is not set" >> ${fragment_file}
    fi
@vfazio vfazio mentioned this issue Jun 25, 2023
Closed
arnout pushed a commit to buildroot/buildroot that referenced this issue Jul 23, 2023
@vfazio @tpetazzoni
toolchain/toolchain-external/toolchain-external-bootlin: flag OpenMP …
746ac56 
…support

The fragments provided by toolchains.bootlin.com were incorrectly
flagging toolchains as not having OpenMP support while they had it
[0]. This has been fixed in toolchains.bootlin.com, so a run of
gen-bootlin-toolchains has allowed to adjust the toolchain definitions
in Buildroot, leading to this commit.

OpenMP support needs to be flagged so the proper libraries get copied
into the resultant filesystem to avoid missing dependencies [1].

[0]: bootlin/toolchains-builder#60
[1]: https://bugs.busybox.net/show_bug.cgi?id=15634

Signed-off-by: Vincent Fazio <vfazio@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
@tpetazzoni
Copy link
Contributor

Fixed by fe71b74

arnout pushed a commit to buildroot/buildroot that referenced this issue Aug 29, 2023
@vfazio @jacmet
toolchain/toolchain-external/toolchain-external-bootlin: flag OpenMP …
01a58f5 
…support

The fragments provided by toolchains.bootlin.com were incorrectly
flagging toolchains as not having OpenMP support while they had it
[0]. This has been fixed in toolchains.bootlin.com, so a run of
gen-bootlin-toolchains has allowed to adjust the toolchain definitions
in Buildroot, leading to this commit.

OpenMP support needs to be flagged so the proper libraries get copied
into the resultant filesystem to avoid missing dependencies [1].

[0]: bootlin/toolchains-builder#60
[1]: https://bugs.busybox.net/show_bug.cgi?id=15634

Signed-off-by: Vincent Fazio <vfazio@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
(cherry picked from commit 746ac56)
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
arnout pushed a commit to buildroot/buildroot that referenced this issue Aug 29, 2023
@vfazio @jacmet
toolchain/toolchain-external/toolchain-external-bootlin: flag OpenMP …
a3cfb1f 
…support

The fragments provided by toolchains.bootlin.com were incorrectly
flagging toolchains as not having OpenMP support while they had it
[0]. This has been fixed in toolchains.bootlin.com, so a run of
gen-bootlin-toolchains has allowed to adjust the toolchain definitions
in Buildroot, leading to this commit.

OpenMP support needs to be flagged so the proper libraries get copied
into the resultant filesystem to avoid missing dependencies [1].

[0]: bootlin/toolchains-builder#60
[1]: https://bugs.busybox.net/show_bug.cgi?id=15634

Signed-off-by: Vincent Fazio <vfazio@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
(cherry picked from commit 746ac56)
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
citral23 pushed a commit to citral23/buildroot that referenced this issue Sep 18, 2023
@vfazio
toolchain/toolchain-external/toolchain-external-bootlin: flag OpenMP …
b33df33 
…support

The fragments provided by toolchains.bootlin.com were incorrectly
flagging toolchains as not having OpenMP support while they had it
[0]. This has been fixed in toolchains.bootlin.com, so a run of
gen-bootlin-toolchains has allowed to adjust the toolchain definitions
in Buildroot, leading to this commit.

OpenMP support needs to be flagged so the proper libraries get copied
into the resultant filesystem to avoid missing dependencies [1].

[0]: bootlin/toolchains-builder#60
[1]: https://bugs.busybox.net/show_bug.cgi?id=15634

Signed-off-by: Vincent Fazio <vfazio@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build-toolchain.sh: add D and OpenMP checks vfazio/toolchains-builder
2 participants
@tpetazzoni @vfazio