Allow label options to be passed in as a hash #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generating fields, it should be possible to specify a hash in the
format of `label: { text: "A label", class: "a-class" }`, as indicated
in the documentation.
This approach assumes that if the developer has specified the label as a
hash, then it trumps `label_class` in the options hash.
Contributor
Author
|
I'd love feedback on this - from a high level, the feature is just filling out functionality that's mentioned in the README (and is pretty useful). However, there is some opinion here in what the precedence of multiple options should be. Currently it's (in descending order):
|
|
This is something I could really use. 👍 |
|
👍 Is there anything I can do to help this get merged? Lost quite a bit of time debugging this until I found this fix. |
|
I could really use this 👍 |
Contributor
|
Looks great! 👏 @bootstrap-ruby, seems ready to 🚢. What do you think? |
potenza
added a commit
that referenced
this pull request
Nov 4, 2015
Allow label options to be passed in as a hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating fields, it should be possible to specify a hash in the
format of
label: { text: "A label", class: "a-class" }, as indicatedin the documentation.
This approach assumes that if the developer has specified the label as a
hash, then it trumps
label_classin the options hash.