Getting rid of alias_method_chain #248
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
Contributor
|
Is there anything I can do to move this forward? |
|
It would sure be nice to fix this conflict and get this PR merged. |
Closed
Contributor
|
I'm planning to close this PR in favor of merging #267. Please let me know if you disagree. |
|
#267 looks good to me. |
Contributor
|
Closed in favor of #267 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heya,
So Rails 5 is coming out eventually, and
alias_method_chainis not a thing for a very long time now. This PR removes the need for it. Also I moved setup helper method so it's not global.Cheers.