Skip to content

Conversation

@narugami
Copy link

@narugami narugami commented Mar 5, 2016

This commit becomes to be compatible with Rails5, but requires Rails4.2+ and Ruby2.2+.

Related issues: #253 , #248.

@siegy22
Copy link
Contributor

siegy22 commented Mar 10, 2016

I don't think this is going to be merged.
I think you'll have to support legacy stuff too..
See getsentry/raven-ruby@8d8e34c
Btw. why are you using ruby 2.2+?
I think if you'd use 2.0+ (which supports Module#prepend) the change is higher that they will merge this.

@benpolinsky
Copy link

+1

@dankohn
Copy link

dankohn commented May 17, 2016

Hi, I can confirm that this pull request enables the use of rails-bootstrap-forms with Rails 5, eliminating the 20 errors of DEPRECATION WARNING: alias_method_chain is deprecated. Please, use Module#prepend instead. From module, you can access the original method using super. (called from <top (required)> at /Users/dan/Dropbox/Documents/dev/cii-best-practices-badge/config/application.rb:8).

You can include it in your Gemfile with:

gem 'bootstrap_form', git: 'https://github.com/narugami/rails-bootstrap-forms',
                      ref: '0d8607f'

@mattbrictson
Copy link
Contributor

Here's an alternative PR that fixes the deprecation warnings but maintains Ruby 1.9 compatibility: #267.

@mattbrictson
Copy link
Contributor

I'm planning to close this PR in favor of merging #267. Please let me know if you disagree.

@mattbrictson
Copy link
Contributor

Closed in favor of #267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants