Prevent mutating (possibly) frozen strings #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the `#form_group` method attempts to mutate the `:control_col` option if no label is supplied. Since this option is passed by the user, it may be a frozen string literal. Instead, we simply avoid mutating the supplied string. As we approach Ruby 3 and frozen string literals become more common, this is more likely to fail.
danielfone
force-pushed
the
fix-string-mutation-in-form-group
branch
from
96e9984 to
6eba354
Compare
|
|
||
| if get_group_layout(options[:layout]) == :horizontal | ||
| control_class = (options[:control_col] || control_col.clone) | ||
| control_class = options[:control_col] || control_col |
Contributor
Author
There was a problem hiding this comment.
This offers a slight memory improvement since it's only creating new string objects as needed, instead of cloning every time.
Contributor
|
Nice improvement. Thanks! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
#form_groupmethod attempts to mutate the:control_coloption if no label is supplied. Since this option ispassed by the user, it may be a frozen string literal. Instead, we
simply avoid mutating the supplied string.
As we approach Ruby 3 and frozen string literals become more common,
this is more likely to fail.
*edit: updated changelog.