Add Rubocop linting to CI and make source files pass linting. #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Results of running Rubocop autocorrect for only the linting rules.
One curious thing: Rubocop autocorrected one line to use the "&." operator, and the next time complained that it wasn't supported. I reverted that change.
Results of running Rubocop autocorrect for only the linting rules.
One curious thing: Rubocop autocorrected one line to use the "&." operator, and the next time complained that it wasn't supported. I reverted that change.
* Took the template from https://github.com/mattbrictson/rails-template/blob/master/rubocop.yml.tt, and modified for the Rails app being in demo/. * Fixed the Ruby version to 2.2.2: the earliest we currently support.
Here's an example of a CHANGELOG.md entry (place it immediately under the * [#486](https://github.com/bootstrap-ruby/bootstrap_form/pull/486): Add Rubocop linting to CI and make source files pass linting. - [@lcreid](https://github.com/lcreid).Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first step in encouraging consistent coding style is
bootstrap_form. It:rubocoptask to theRakefile, and runsrubocopas part of the default tasks, so checks will be done by Travis..rubocop_todo.ymlfor the remaining offences.This PR addresses the checklist items in #481.
Fixes #481.