diff --git a/.github/workflows/ruby.yml b/.github/workflows/ruby.yml index 89ec201b..87f25c25 100644 --- a/.github/workflows/ruby.yml +++ b/.github/workflows/ruby.yml @@ -56,3 +56,8 @@ jobs: - name: Run tests working-directory: demo run: bundle exec rake test:all + - name: Commit changed screenshots and other files + if: failure() + working-directory: demo + run: bundle exec rake commit + diff --git a/.gitignore b/.gitignore index 44b16c24..335a89d7 100644 --- a/.gitignore +++ b/.gitignore @@ -54,6 +54,7 @@ vendor/bundle # or .local/share/pry/pry_history if you need to be more exact .local/ .irb_history +.rdbg_history .byebug_history # For Debian images with Bash .bash_history diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e6f49742..001af2df 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -50,6 +50,36 @@ You may find the [demo application](#the-demo-application) useful for developmen - If your PR fixes an issues, be sure to put "Fixes #nnn" in the description of the PR (where `nnn` is the issue number). Github will automatically close the issue when the PR is merged. - When the PR is submitted, check if GitHub Actions ran all the tests successfully, and didn't raise any issues. +When you create or update a pull request, GitHub automatically runs tests that generate the screenshots in the [`README.md`](/README.md). If any of the screenshots change, GitHub will add an additional commit with the updated screenshots. + +Normally, the screenshots should _not_ change. If the screenshots changed, please review them _carefully_. Some clear reasons why you would want to keep the changed screenshots: + +- Your PR was fixing behaviour that was wrong in the screenshot. +- You added new examples in the documentation, so there are new screenshots. +- A change to the images used by GitHub in their actions changes the behaviour of Chrome, although if you think it's this you should probably prepare a separate PR that _only_ updates the screenshots, so it's clear what the change is and why we're making the change. + +Unless you have one of the above reasons, or you have a good explanation for why the screenshots have changed with your PR, you need to get rid of the changed screenshots (i.e. revert the last commit) and fix your PR so the screenshots don't change. (The reason you should revert the commit with the screenshots is so that the next time you push, GitHub will compare against the original screenshots, not the ones changed by your previous push.) Here's how to get rid of the changed screenshots: + +```bash +git pull # to bring the additional commit to your local branch. +git revert HEAD # to remove the changes. +``` + +Then fix the code and push your branch again. + +If the change was intended, a comment in the PR explaing why the change is expected would be very much appreciated. More than appreciated. It will avoid us having to ask you for an explanation. + +You can run the tests that generate the screenshots locally, but unless your environment is very much like the GitHub CI environment -- Ubuntu running Chrome with default fonts -- all the screenshots will be reported as having changed. To generate the screenshots: + +```bash +cd demo +bundle exec rails test:all +``` + +The [Docker development environment](#using-docker-compose) appears to generate screenshots that are the same as what GitHub generates. + +Finally, maintainers may sometimes push changes directly to `main` or use other workflows to update the code. If pushing to `main` generates a commit for screenshot changes, please consider reverting your change immediately by executing the above `pull` and `revert` and another `push`, for the sanity of users who are using the edge (`main` branch) version of the gem. At any rate, review the changes promptly and use your judgement. + ### 7. Done Somebody will shortly review your pull request and if everything is good, it will be diff --git a/README.md b/README.md index dc39c303..00d2f4a9 100644 --- a/README.md +++ b/README.md @@ -1064,7 +1064,7 @@ will be rendered as: - + ``` diff --git a/demo/app/views/layouts/application.html.erb b/demo/app/views/layouts/application.html.erb index 745064af..bbff7eb8 100644 --- a/demo/app/views/layouts/application.html.erb +++ b/demo/app/views/layouts/application.html.erb @@ -3,8 +3,6 @@ Hello, world! - - diff --git a/demo/doc/screenshots/bootstrap/index/00_horizontal_form.png b/demo/doc/screenshots/bootstrap/index/00_horizontal_form.png index 532bff72..4df30587 100644 Binary files a/demo/doc/screenshots/bootstrap/index/00_horizontal_form.png and b/demo/doc/screenshots/bootstrap/index/00_horizontal_form.png differ diff --git a/demo/doc/screenshots/bootstrap/index/01_with_validation_error.png b/demo/doc/screenshots/bootstrap/index/01_with_validation_error.png index 864dd678..4039ab08 100644 Binary files a/demo/doc/screenshots/bootstrap/index/01_with_validation_error.png and b/demo/doc/screenshots/bootstrap/index/01_with_validation_error.png differ diff --git a/demo/doc/screenshots/bootstrap/index/02_inline_form.png b/demo/doc/screenshots/bootstrap/index/02_inline_form.png index f07c8756..f109d909 100644 Binary files a/demo/doc/screenshots/bootstrap/index/02_inline_form.png and b/demo/doc/screenshots/bootstrap/index/02_inline_form.png differ diff --git a/demo/doc/screenshots/bootstrap/index/03_simple_action_text_example.png b/demo/doc/screenshots/bootstrap/index/03_simple_action_text_example.png index 18a1f924..4b0ee60c 100644 Binary files a/demo/doc/screenshots/bootstrap/index/03_simple_action_text_example.png and b/demo/doc/screenshots/bootstrap/index/03_simple_action_text_example.png differ diff --git a/demo/doc/screenshots/bootstrap/index/04_floating_labels.png b/demo/doc/screenshots/bootstrap/index/04_floating_labels.png index c30039bd..4305ed1d 100644 Binary files a/demo/doc/screenshots/bootstrap/index/04_floating_labels.png and b/demo/doc/screenshots/bootstrap/index/04_floating_labels.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/00_example.png b/demo/doc/screenshots/bootstrap/readme/00_example.png index 2a0c955b..b341338c 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/00_example.png and b/demo/doc/screenshots/bootstrap/readme/00_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/01_example.png b/demo/doc/screenshots/bootstrap/readme/01_example.png index 78f8611a..6bf4d866 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/01_example.png and b/demo/doc/screenshots/bootstrap/readme/01_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/02_example.png b/demo/doc/screenshots/bootstrap/readme/02_example.png index 268dcb18..18e40e03 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/02_example.png and b/demo/doc/screenshots/bootstrap/readme/02_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/03_example.png b/demo/doc/screenshots/bootstrap/readme/03_example.png index ba465fdb..4c57e99f 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/03_example.png and b/demo/doc/screenshots/bootstrap/readme/03_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/04_example.png b/demo/doc/screenshots/bootstrap/readme/04_example.png index 63869762..c46284ca 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/04_example.png and b/demo/doc/screenshots/bootstrap/readme/04_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/05_example.png b/demo/doc/screenshots/bootstrap/readme/05_example.png index f37aeee2..6d8c0267 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/05_example.png and b/demo/doc/screenshots/bootstrap/readme/05_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/06_example.png b/demo/doc/screenshots/bootstrap/readme/06_example.png index ea01ff3a..222940dc 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/06_example.png and b/demo/doc/screenshots/bootstrap/readme/06_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/07_example.png b/demo/doc/screenshots/bootstrap/readme/07_example.png index 2e2738ea..156c9204 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/07_example.png and b/demo/doc/screenshots/bootstrap/readme/07_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/08_example.png b/demo/doc/screenshots/bootstrap/readme/08_example.png index 9b64b1b0..d6857c70 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/08_example.png and b/demo/doc/screenshots/bootstrap/readme/08_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/09_example.png b/demo/doc/screenshots/bootstrap/readme/09_example.png index 2aa352b7..f1a60387 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/09_example.png and b/demo/doc/screenshots/bootstrap/readme/09_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/10_example.png b/demo/doc/screenshots/bootstrap/readme/10_example.png index 75032214..d2157dec 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/10_example.png and b/demo/doc/screenshots/bootstrap/readme/10_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/11_example.png b/demo/doc/screenshots/bootstrap/readme/11_example.png index b16c2634..293f38af 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/11_example.png and b/demo/doc/screenshots/bootstrap/readme/11_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/12_example.png b/demo/doc/screenshots/bootstrap/readme/12_example.png index 922620f1..d2038f1d 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/12_example.png and b/demo/doc/screenshots/bootstrap/readme/12_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/13_example.png b/demo/doc/screenshots/bootstrap/readme/13_example.png index 57778773..414d6558 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/13_example.png and b/demo/doc/screenshots/bootstrap/readme/13_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/14_example.png b/demo/doc/screenshots/bootstrap/readme/14_example.png index b994080c..03066565 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/14_example.png and b/demo/doc/screenshots/bootstrap/readme/14_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/15_example.png b/demo/doc/screenshots/bootstrap/readme/15_example.png index 13377155..a80459b1 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/15_example.png and b/demo/doc/screenshots/bootstrap/readme/15_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/16_example.png b/demo/doc/screenshots/bootstrap/readme/16_example.png index d3ebd2fa..269e3228 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/16_example.png and b/demo/doc/screenshots/bootstrap/readme/16_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/17_example.png b/demo/doc/screenshots/bootstrap/readme/17_example.png index 896075bf..6f6bfc88 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/17_example.png and b/demo/doc/screenshots/bootstrap/readme/17_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/18_example.png b/demo/doc/screenshots/bootstrap/readme/18_example.png index c7cd229c..4d9a6539 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/18_example.png and b/demo/doc/screenshots/bootstrap/readme/18_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/19_example.png b/demo/doc/screenshots/bootstrap/readme/19_example.png index c30eaa69..260f5a9d 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/19_example.png and b/demo/doc/screenshots/bootstrap/readme/19_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/20_example.png b/demo/doc/screenshots/bootstrap/readme/20_example.png index 2c9f0c09..55007bea 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/20_example.png and b/demo/doc/screenshots/bootstrap/readme/20_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/21_example.png b/demo/doc/screenshots/bootstrap/readme/21_example.png index e4b8dd64..98802cb4 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/21_example.png and b/demo/doc/screenshots/bootstrap/readme/21_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/22_example.png b/demo/doc/screenshots/bootstrap/readme/22_example.png index 71306897..13fc60f4 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/22_example.png and b/demo/doc/screenshots/bootstrap/readme/22_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/23_example.png b/demo/doc/screenshots/bootstrap/readme/23_example.png index 9d456ef8..2d565d9e 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/23_example.png and b/demo/doc/screenshots/bootstrap/readme/23_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/24_example.png b/demo/doc/screenshots/bootstrap/readme/24_example.png index a1f24eb2..4ea72204 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/24_example.png and b/demo/doc/screenshots/bootstrap/readme/24_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/25_example.png b/demo/doc/screenshots/bootstrap/readme/25_example.png index c8c1bca0..ccc2344f 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/25_example.png and b/demo/doc/screenshots/bootstrap/readme/25_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/26_example.png b/demo/doc/screenshots/bootstrap/readme/26_example.png index 03cf4f86..b844dd16 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/26_example.png and b/demo/doc/screenshots/bootstrap/readme/26_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/27_example.png b/demo/doc/screenshots/bootstrap/readme/27_example.png index 8a7af9ec..1b3da669 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/27_example.png and b/demo/doc/screenshots/bootstrap/readme/27_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/28_example.png b/demo/doc/screenshots/bootstrap/readme/28_example.png index 650b2aec..38febad7 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/28_example.png and b/demo/doc/screenshots/bootstrap/readme/28_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/29_example.png b/demo/doc/screenshots/bootstrap/readme/29_example.png index 7570ce7a..366869b4 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/29_example.png and b/demo/doc/screenshots/bootstrap/readme/29_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/30_example.png b/demo/doc/screenshots/bootstrap/readme/30_example.png index 7570ce7a..366869b4 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/30_example.png and b/demo/doc/screenshots/bootstrap/readme/30_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/31_example.png b/demo/doc/screenshots/bootstrap/readme/31_example.png index b3153872..d16b1cc5 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/31_example.png and b/demo/doc/screenshots/bootstrap/readme/31_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/32_example.png b/demo/doc/screenshots/bootstrap/readme/32_example.png index 9e83ec13..093cc6e7 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/32_example.png and b/demo/doc/screenshots/bootstrap/readme/32_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/33_example.png b/demo/doc/screenshots/bootstrap/readme/33_example.png index 30edc299..40914fe0 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/33_example.png and b/demo/doc/screenshots/bootstrap/readme/33_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/34_example.png b/demo/doc/screenshots/bootstrap/readme/34_example.png index d804a412..289ac914 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/34_example.png and b/demo/doc/screenshots/bootstrap/readme/34_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/35_example.png b/demo/doc/screenshots/bootstrap/readme/35_example.png index ee42af4b..790491dd 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/35_example.png and b/demo/doc/screenshots/bootstrap/readme/35_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/36_example.png b/demo/doc/screenshots/bootstrap/readme/36_example.png index e261e046..aa7be34d 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/36_example.png and b/demo/doc/screenshots/bootstrap/readme/36_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/37_example.png b/demo/doc/screenshots/bootstrap/readme/37_example.png index b7217522..b0778a23 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/37_example.png and b/demo/doc/screenshots/bootstrap/readme/37_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/38_example.png b/demo/doc/screenshots/bootstrap/readme/38_example.png index 2dd87500..954467a5 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/38_example.png and b/demo/doc/screenshots/bootstrap/readme/38_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/39_example.png b/demo/doc/screenshots/bootstrap/readme/39_example.png index 74ebae27..0ba3ae70 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/39_example.png and b/demo/doc/screenshots/bootstrap/readme/39_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/40_example.png b/demo/doc/screenshots/bootstrap/readme/40_example.png index 7dff6588..87510127 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/40_example.png and b/demo/doc/screenshots/bootstrap/readme/40_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/41_example.png b/demo/doc/screenshots/bootstrap/readme/41_example.png index b2e63ab3..fd9e75a2 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/41_example.png and b/demo/doc/screenshots/bootstrap/readme/41_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/42_example.png b/demo/doc/screenshots/bootstrap/readme/42_example.png index 39042fa1..fd4ecaa7 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/42_example.png and b/demo/doc/screenshots/bootstrap/readme/42_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/43_example.png b/demo/doc/screenshots/bootstrap/readme/43_example.png index 98539476..032e0ce5 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/43_example.png and b/demo/doc/screenshots/bootstrap/readme/43_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/44_example.png b/demo/doc/screenshots/bootstrap/readme/44_example.png index 113e3acb..a07103fc 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/44_example.png and b/demo/doc/screenshots/bootstrap/readme/44_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/45_example.png b/demo/doc/screenshots/bootstrap/readme/45_example.png index b786657c..f08e6fc1 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/45_example.png and b/demo/doc/screenshots/bootstrap/readme/45_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/46_example.png b/demo/doc/screenshots/bootstrap/readme/46_example.png index bee9737c..27c42f5d 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/46_example.png and b/demo/doc/screenshots/bootstrap/readme/46_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/47_example.png b/demo/doc/screenshots/bootstrap/readme/47_example.png index 10eef24e..d2f4c637 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/47_example.png and b/demo/doc/screenshots/bootstrap/readme/47_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/48_example.png b/demo/doc/screenshots/bootstrap/readme/48_example.png index 07e45869..b8d12377 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/48_example.png and b/demo/doc/screenshots/bootstrap/readme/48_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/49_example.png b/demo/doc/screenshots/bootstrap/readme/49_example.png index 0fb21c6d..52a3d8c6 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/49_example.png and b/demo/doc/screenshots/bootstrap/readme/49_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/50_example.png b/demo/doc/screenshots/bootstrap/readme/50_example.png index 8748b832..128c12e3 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/50_example.png and b/demo/doc/screenshots/bootstrap/readme/50_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/51_example.png b/demo/doc/screenshots/bootstrap/readme/51_example.png index 8748b832..128c12e3 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/51_example.png and b/demo/doc/screenshots/bootstrap/readme/51_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/52_example.png b/demo/doc/screenshots/bootstrap/readme/52_example.png index 5fe3d9f0..1666a6d9 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/52_example.png and b/demo/doc/screenshots/bootstrap/readme/52_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/53_example.png b/demo/doc/screenshots/bootstrap/readme/53_example.png index 4a0f562b..da6ce83b 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/53_example.png and b/demo/doc/screenshots/bootstrap/readme/53_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/54_example.png b/demo/doc/screenshots/bootstrap/readme/54_example.png index 140d2104..9218e810 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/54_example.png and b/demo/doc/screenshots/bootstrap/readme/54_example.png differ diff --git a/demo/doc/screenshots/bootstrap/readme/55_example.png b/demo/doc/screenshots/bootstrap/readme/55_example.png index 776ffa92..cdd44f26 100644 Binary files a/demo/doc/screenshots/bootstrap/readme/55_example.png and b/demo/doc/screenshots/bootstrap/readme/55_example.png differ diff --git a/demo/lib/tasks/commit.rake b/demo/lib/tasks/commit.rake new file mode 100644 index 00000000..bab35e02 --- /dev/null +++ b/demo/lib/tasks/commit.rake @@ -0,0 +1,18 @@ +# frozen_string_literal: true + +desc <<~DESC + Commit changed files, if any. Meant to be used in CI to commit automatically created files + (e.g. screenshots). +DESC +task :commit do # rubocop:disable Rails/RakeEnvironment + msg = <<~MSG + Changed in CI + Please review the changes in the files in this commit + carefully, as they were automatically generated during CI. + Run `git pull` to bring the changes into your local branch. + Then, if you do not want the changes, run `git revert HEAD`. + MSG + system("git config user.name github-actions") + system("git config user.email github-actions@github.com") + system("git diff --exit-code -s || git commit --all -m '#{msg}' && git push") +end diff --git a/demo/test/application_system_test_case.rb b/demo/test/application_system_test_case.rb index 842f0d85..7913de3f 100644 --- a/demo/test/application_system_test_case.rb +++ b/demo/test/application_system_test_case.rb @@ -27,6 +27,6 @@ def remote_selenium? = @remote_selenium ||= ENV["SELENIUM_HOST"].present? || ENV Capybara.app_host = "http://#{ENV.fetch('TEST_APP_HOST', 'shell')}:#{ENV.fetch('TEST_APP_PORT', Capybara.server_port)}" end - Capybara::Screenshot.enabled = ENV["CI"].blank? + Capybara::Screenshot.enabled = true Capybara.server = :puma, { Silent: true } end