Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] Removing old Rails checks #381

Merged
merged 1 commit into from Jan 17, 2018

Conversation

GBH
Copy link
Contributor

@GBH GBH commented Jan 16, 2018

Since we don't care about Rails 3 and 4 we don't need those checks (not like any of that stuff was tested anyways)

@bootstrap-ruby-bot
Copy link

1 Warning
⚠️ Please update CHANGELOG.md with a description of your changes. If this PR is not a user-facing change (e.g. just refactoring), you can disregard this.

Here's an example of a CHANGELOG.md entry (place it immediately under the * Your contribution here! line):

* [#381](https://github.com/bootstrap-ruby/rails-bootstrap-forms/pull/381): [v4] Removing old Rails checks - [@GBH](https://github.com/GBH).

Generated by 🚫 Danger

Copy link
Contributor

@lcreid lcreid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I was debating whether to ask for a CHANGELOG entry, but I'll let this one go without.

@mattbrictson
Copy link
Contributor

Thanks, nice cleanup 🙌

@mattbrictson mattbrictson merged commit 6fde0fc into bootstrap-ruby:master Jan 17, 2018
@mattbrictson mattbrictson added this to the 4.0.0 milestone Jan 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants