Permalink
Browse files

fix(tabs): Apply `small` class to parent `ul.nav` (#1255)

* fix(tabs): Apply `small` class to parent `ul.nav`

Applying the `small` class to the parent `ul.nav` rather than the individual `nav-items` allows for proper sizing of items added to the "tabs" named slot.

Addresses issues #1248

* Update tabs.vue
  • Loading branch information...
tmorehouse committed Oct 27, 2017
1 parent 81989ab commit 42f8a7813a9185cc32c2bdc1bbcb313607ab435a
Showing with 3 additions and 3 deletions.
  1. +3 −3 lib/components/tabs.vue
@@ -6,7 +6,7 @@
</div>
<div :class="{'card-header': card}">
<ul :class="['nav','nav-' + navStyle, card ? 'card-header-'+navStyle : null]"
<ul :class="['nav','nav-' + navStyle, card ? 'card-header-'+navStyle : null, small ? 'small' : '']"
role="tablist"
tabindex="0"
@keydown.left="previousTab"
@@ -18,8 +18,8 @@
@keydown.shift.right="setTab(tabs.length-1,false,-1)"
@keydown.shift.down="setTab(tabs.length-1,false,-1)"
>
<li class="nav-item" v-for="(tab, index) in tabs" role="presentation">
<a :class="['nav-link',{small: small, active: tab.localActive, disabled: tab.disabled}]"
<li class="'nav-item" v-for="(tab, index) in tabs" role="presentation">
<a :class="['nav-link',{active: tab.localActive, disabled: tab.disabled}]"
:href="tab.href"
role="tab"
:aria-setsize="tabs.length"

0 comments on commit 42f8a78

Please sign in to comment.