From dc67dd3f5963eb2db865418f5f13d9a8dfed0037 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jacob=20M=C3=BCller?= <jacob.mueller.elz@gmail.com>
Date: Fri, 22 Jan 2021 11:21:34 +0100
Subject: [PATCH 1/2] fix(b-form-group): remove `role="alert"` from
 valid/invalid feedback

---
 src/components/form-group/form-group.js | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/components/form-group/form-group.js b/src/components/form-group/form-group.js
index c9c7a990080..ed16deccf76 100644
--- a/src/components/form-group/form-group.js
+++ b/src/components/form-group/form-group.js
@@ -305,7 +305,6 @@ export const BFormGroup = {
           props: {
             ariaLive: feedbackAriaLive,
             id: invalidFeedbackId,
-            role: feedbackAriaLive ? 'alert' : null,
             // If state is explicitly `false`, always show the feedback
             state,
             tooltip
@@ -326,7 +325,6 @@ export const BFormGroup = {
           props: {
             ariaLive: feedbackAriaLive,
             id: validFeedbackId,
-            role: feedbackAriaLive ? 'alert' : null,
             // If state is explicitly `true`, always show the feedback
             state,
             tooltip

From 43f232abb5ee0c88806453a26622f9d3932f851b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jacob=20M=C3=BCller?= <jacob.mueller.elz@gmail.com>
Date: Fri, 22 Jan 2021 11:22:48 +0100
Subject: [PATCH 2/2] Update form-group.spec.js

---
 src/components/form-group/form-group.spec.js | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/components/form-group/form-group.spec.js b/src/components/form-group/form-group.spec.js
index f1f1cc95527..1f308ac5e6f 100644
--- a/src/components/form-group/form-group.spec.js
+++ b/src/components/form-group/form-group.spec.js
@@ -321,14 +321,12 @@ describe('form-group', () => {
     const $invalidFeedback = wrapper.find('.invalid-feedback')
     expect($invalidFeedback.exists()).toBe(true)
     expect($invalidFeedback.text()).toEqual('bar')
-    expect($invalidFeedback.attributes('role')).toEqual('alert')
     expect($invalidFeedback.attributes('aria-live')).toEqual('assertive')
     expect($invalidFeedback.attributes('aria-atomic')).toEqual('true')
 
     const $validFeedback = wrapper.find('.valid-feedback')
     expect($validFeedback.exists()).toBe(true)
     expect($validFeedback.text()).toEqual('baz')
-    expect($validFeedback.attributes('role')).toEqual('alert')
     expect($validFeedback.attributes('aria-live')).toEqual('assertive')
     expect($validFeedback.attributes('aria-atomic')).toEqual('true')
 
@@ -373,14 +371,12 @@ describe('form-group', () => {
     let $invalidFeedback = wrapper.find('.invalid-feedback')
     expect($invalidFeedback.exists()).toBe(true)
     expect($invalidFeedback.text()).toEqual('bar')
-    expect($invalidFeedback.attributes('role')).toEqual('alert')
     expect($invalidFeedback.attributes('aria-live')).toEqual('polite')
     expect($invalidFeedback.attributes('aria-atomic')).toEqual('true')
 
     let $validFeedback = wrapper.find('.valid-feedback')
     expect($validFeedback.exists()).toBe(true)
     expect($validFeedback.text()).toEqual('baz')
-    expect($validFeedback.attributes('role')).toEqual('alert')
     expect($validFeedback.attributes('aria-live')).toEqual('polite')
     expect($validFeedback.attributes('aria-atomic')).toEqual('true')