From acb13b268528c8a4e80b5ecb4162ff37f6987f0b Mon Sep 17 00:00:00 2001
From: Troy Morehouse <troymore@nbnet.nb.ca>
Date: Mon, 26 Jun 2017 00:56:41 -0300
Subject: [PATCH] [button] Add support for button type attribute (#549)

* [button] Add support for button type attribute

Adds new prop `type` which defaults to "button".

Only applied if neither `href` nor `to` prop are provided.
---
 lib/components/button.vue | 20 +++++++++-----------
 1 file changed, 9 insertions(+), 11 deletions(-)

diff --git a/lib/components/button.vue b/lib/components/button.vue
index a81cae5390f..0d3569d5795 100755
--- a/lib/components/button.vue
+++ b/lib/components/button.vue
@@ -2,6 +2,7 @@
     <button v-bind="conditionalLinkProps"
             :is="componentType"
             :class="classList"
+            :type="btnType"
             :disabled="disabled"
             @click="onClick">
         <slot></slot>
@@ -23,10 +24,8 @@ const linkProps = Object.assign(omitLinkProps('href', 'to'), {
 
 export default {
     components: { bLink },
-
     computed: {
         linkProps: computed.linkProps,
-
         classList() {
             return [
                 'btn',
@@ -36,32 +35,28 @@ export default {
                 this.btnDisabled
             ];
         },
-
         componentType() {
             return (this.href || this.to) ? 'b-link' : 'button';
         },
-
         btnBlock() {
             return this.block ? `btn-block` : '';
         },
-
         btnVariant() {
             return this.variant ? `btn-${this.variant}` : `btn-secondary`;
         },
-
         btnSize() {
             return this.size ? `btn-${this.size}` : '';
         },
-
         btnDisabled() {
             return this.disabled ? 'disabled' : '';
         },
-
+        btnType() {
+            return (this.href || this.to) ? null : this.type; 
+        },
         conditionalLinkProps() {
             return this.componentType === 'button' ? {} : this.linkProps;
-        },
+        }
     },
-
     // merge our prepared link props with button props
     props: Object.assign(linkProps, {
         block: {
@@ -80,8 +75,11 @@ export default {
             type: String,
             default: null
         },
+        type: {
+            type: String,
+            default: 'button'
+        }
     }),
-
     methods: {
         onClick(e) {
             if (this.disabled) {