Permalink
Browse files

fix(button-close): Hardcode × character to prevent SSR bailing

  • Loading branch information...
tmorehouse committed Sep 27, 2017
1 parent 9a19479 commit b0dd1ba175dad8456f931a84973c214375f9a7e7
Showing with 1 addition and 1 deletion.
  1. +1 −1 lib/components/button-close.js
@@ -41,7 +41,7 @@ export default {
};
// Careful not to override the slot with innerHTML
if (!children.length) {
componentData.domProps = { innerHTML: "×" };
componentData.domProps = { innerTEXT: "×" };
}
return h("button", mergeData(data, componentData), children);
}

1 comment on commit b0dd1ba

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented on b0dd1ba Oct 12, 2017

For some reason, modern browsers interpret × into an actual UTF-8 character, rather than leaving it as the entity code. Hence we have hard-coded the UTF-* character rather than the entity code.

Please sign in to comment.