Permalink
Browse files

fix(form-input): isTextArea varname correction (#785)

* fix(form-input): isTextArea varname correction

* fix(jest): enable max workers flag for CI
  • Loading branch information...
alexsasharegan authored and tmorehouse committed Aug 9, 2017
1 parent 5d7ed2a commit cb44652f2e49b6399bd12cb31b1575f94922b666
Showing with 5 additions and 5 deletions.
  1. +4 −4 lib/components/form-input.vue
  2. +1 −1 package.json
@@ -1,8 +1,8 @@
<template>
<input v-if="!static"
ref="input"
:is="isTextarea ? 'textarea' : 'input'"
:type="isTextarea ? null : type"
:is="isTextArea ? 'textarea' : 'input'"
:type="isTextArea ? null : type"
:value="value"
:name="name"
:id="id || null"
@@ -13,7 +13,7 @@
:aria-invalid="ariaInvalid"
:readonly="readonly"
:class="inputClass"
:rows="isTextarea ? (rows || rowsCount) : null"
:rows="isTextArea ? (rows || rowsCount) : null"
:placeholder="placeholder"
@input="onInput($event.target.value, $event.target)"
@change="onChange($event.target.value, $event.target)"
@@ -37,7 +37,7 @@
mixins: [formMixin],
components: {bFormInputStatic},
computed: {
istextarea() {
isTextArea() {
return this.textarea || this.type === 'textarea';
},
rowsCount() {
@@ -52,7 +52,7 @@
"docs-dev": "nuxt dev",
"docs-gen": "nuxt generate",
"docs-publish": "./build/gh-pages",
"test": "jest",
"test": "jest --maxWorkers=4",

This comment has been minimized.

@pi0

pi0 Aug 9, 2017

Member

Hi! This flag is already set to 1 in .circleci config too is there any reason setting it here?

This comment has been minimized.

@alexsasharegan

alexsasharegan Aug 9, 2017

Contributor

Weird. It doesn't seem to work in circle ci because adding that flag fixes a consistent set of build errors.

This comment has been minimized.

@alexsasharegan

alexsasharegan Aug 9, 2017

Contributor

Ah, it looks like this was added very recently. Yet I still received the classic build failure message about memory...

This comment has been minimized.

@pi0

pi0 Aug 9, 2017

Member

I will finally find out what process is eating that 4Gbs of RAM in ci :))

This comment has been minimized.

@alexsasharegan

alexsasharegan Aug 9, 2017

Contributor

Obviously feel free to kill this line at any point. And let us know when you figure out what it is!

"prepublish": "npm run build && npm run test",
"postpublish": "npm run docs-publish",
"release": "standard-version"

0 comments on commit cb44652

Please sign in to comment.