Skip to content

Commit

Permalink
fix(tables): add in missing Bootstrap variant class bg-active for d…
Browse files Browse the repository at this point in the history
…ark tables (#4098)
  • Loading branch information
tmorehouse committed Sep 18, 2019
1 parent e35ad51 commit d9900ab
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/_variables.scss
Expand Up @@ -88,6 +88,10 @@ $bv-enable-table-stacked: true !default;
$b-table-stacked-heading-width: 40% !default;
$b-table-stacked-gap: 1rem !default;

// Bootstrap v4.3 is missing the "active" variant for dark tables
// Which translates to `bg-active`, but only for tables
$table-dark-active-bg: $table-dark-hover-bg !default;

// --- Toasts ---

// Toaster defaults
Expand Down
11 changes: 11 additions & 0 deletions src/components/table/_table.scss
Expand Up @@ -34,6 +34,17 @@
caption-side: top !important;
}
}

// Add in missing `bg-active` class for table tbody rows
// Bootstrap v4.3 is missing this for dark tables
// `bg-active` class cannot be applied to individual cells
> tbody > .bg-active {
&,
> th,
> td {
background-color: $table-dark-active-bg;
}
}
}

// --- Table sticky header styling ---
Expand Down

0 comments on commit d9900ab

Please sign in to comment.