Permalink
Browse files

fix(modal): rounded-top class no longer needed when header variant ap…

…plied (#1433)

The original bug (twbs/bootstrap#23798) was fixed in Bootstrap V4.beta.2: twbs/bootstrap#23799
  • Loading branch information...
tmorehouse committed Dec 6, 2017
1 parent aa45d3e commit ecf1bf508f945a996cabb91f3efb9aeffa2e6c90
Showing with 0 additions and 4 deletions.
  1. +0 −4 src/components/modal/_modal.js
@@ -383,9 +383,7 @@ export default {
headerClasses () {
return [
'modal-header',
// Rounding is needed to fix a bug in bootstrap V4.beta.1 CSS
{
'rounded-top': Boolean(this.headerBgVariant),
[`bg-${this.headerBgVariant}`]: Boolean(this.headerBgVariant),
[`text-${this.headerTextVariant}`]: Boolean(this.headerTextVariant),
[`border-${this.headerBorderVariant}`]: Boolean(this.headerBorderVariant)
@@ -404,9 +402,7 @@ export default {
footerClasses () {
return [
'modal-footer',
// Rounding is needed to fix a bug in bootstrap V4.beta.1 CSS
{
'rounded-bottom': Boolean(this.footerBgVariant),
[`bg-${this.footerBgVariant}`]: Boolean(this.footerBgVariant),
[`text-${this.footerTextVariant}`]: Boolean(this.footerTextVariant),
[`border-${this.footerBorderVariant}`]: Boolean(this.footerBorderVariant)

0 comments on commit ecf1bf5

Please sign in to comment.