Permalink
Browse files

fix(modal): Fix aria hidden attr and observeDom target element

  • Loading branch information...
tmorehouse committed Sep 12, 2017
1 parent 6cfc682 commit f099ac702468d7546028ce77e7271c70be4f2441
Showing with 2 additions and 2 deletions.
  1. +2 −2 lib/components/modal.vue
@@ -15,7 +15,7 @@
>
<div :class="modalClasses"
:id="safeId()"
:aria-hidden="is_visible ? '' : 'true'"
:aria-hidden="is_visible ? null : 'true'"
role="dialog"
ref="modal"
v-show="is_visible"
@@ -597,7 +597,7 @@
// Listen for bv:modal::show events, and close ourselves if the opening modal not us
this.listenOnRoot('bv::modal::show', this.modalListener);
// Observe changes in modal content and adjust if necessary
observeDom(this.$refs.modal, this.adjustDialog.bind(this), {
observeDom(this.$refs.content, this.adjustDialog.bind(this), {
subtree: true,
childList: true,
attributes: true,

0 comments on commit f099ac7

Please sign in to comment.