feat(modal): Add Bootstrap V4 anticipated verticaly centered modal #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vertically centered modals will be coming in Bootstrap V4.beta.3 This adds a new prop `centered` which renders the modal centered vertically. twbs/bootstrap#24510 Note vertically centered modals are **not** suited for tall content modals, as there is a potential for the header (or top part of the modal) to become inaccessible). They are better suited to one or two line content (i.e. confirmation dialogs). The custom CSS in modal.vue can be removed once V4.beta.3 (or later) arrives
Codecov Report
@@ Coverage Diff @@
## dev #1246 +/- ##
=======================================
Coverage 32.99% 32.99%
=======================================
Files 110 110
Lines 2882 2882
Branches 926 926
=======================================
Hits 951 951
Misses 1551 1551
Partials 380 380
Continue to review full report at Codecov.
|
mosinve
approved these changes
Oct 26, 2017
|
Ive also made a proposal to twbs/BSV4 on handling viewport overflowing vertically centered modals. So maybe once V4.beta.3 rolls around, we can remove the warning in the docs. |
|
Cool.. So we are a step ahead official BS4? ))) |
|
Yep, 1/2 step ahead 🙂 |
56 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vertically centered modals will be coming in Bootstrap V4
twbs/bootstrap#24510
This adds a new prop
centeredwhich renders the modal centered vertically.Note vertically centered modals are not suited for tall content modals, as there is a potential for the header (or top part of the modal) to become inaccessible. They are better suited to one or two line content (i.e. confirmation dialogs).
The custom CSS in modal.vue can be removed once V4.beta.3 (or later) arrives