New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover's body/content removed after hiding all popovers with 'bv::hide::popover' on $root #1322

Closed
josespinal opened this Issue Nov 9, 2017 · 7 comments

Comments

Projects
None yet
2 participants
@josespinal

josespinal commented Nov 9, 2017

Hi,

When I try to close all open popovers on the "@show" event:

onShow () {
      this.$root.$emit('bv::hide::popover')
}

And I try to reopen the popover, I get empty content on it. What could it be?

Edit 1: What gets deleted is the inline content inside the component.

Thanks in advance!!

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Nov 9, 2017

I assume you are using the component version of popover?

Could you provide some sample markup & code?

tmorehouse added a commit that referenced this issue Nov 9, 2017

fix(popover+tooltip): body/content removed after hiding all popovers …
…with 'bv::hide::popover'

Prevents popovers/tooltip from showing empty content when re-opened after emitting `bv::hide::popover/tooltip`

Closes issue: #1322
@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Nov 9, 2017

We were able to recreate the issue, and have a PR that will fix this.

Should be available in the next release.

@josespinal

This comment has been minimized.

josespinal commented Nov 9, 2017

Perfect! Thanks!

tmorehouse added a commit that referenced this issue Nov 9, 2017

fix(popover+tooltip): content not restored after hiding all popovers …
…with 'bv::hide::popover' (#1323)

Prevents popovers/tooltip from showing empty content when re-opened after emitting `bv::hide::popover/tooltip`

Closes issue: #1322
@josespinal

This comment has been minimized.

josespinal commented Nov 9, 2017

Made the changes on the commit, but the problem persists. Anything else needed?

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Nov 9, 2017

I can't reproduce anymore with the latest dev branch which has the commit.

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Nov 9, 2017

I used the following markup as a test(the last button will close other open popovers: when its popover opens)

  <div>
    <b-button id="a">button</b-button>
    <b-button id="b">button</b-button>
    <b-button id="c">button</b-button>
    <b-button id="d">hide others</b-button><br><br>
    <b-popover target="a" triggers="click" placement="top">Hello</b-popover>
    <b-popover target="b" triggers="click" placement="top">Hello</b-popover>
    <b-popover target="c" triggers="click" placement="top">Hello</b-popover>
    <b-popover target="d" triggers="click" placement="top" @show="onShow">Hello</b-popover> 
  </div>

and this script:

{
    methods: {
      onShow() {
        this.$root.$emit('bv::hide::popover')
      }
    }
}

The docs site is running the latest dev branch, so you can paste the above in the playground to see it in action.

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Nov 18, 2017

Fixed in release v1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment