New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect modal button variables #1650

Closed
RomeroMsk opened this Issue Mar 6, 2018 · 6 comments

Comments

Projects
None yet
2 participants
@RomeroMsk
Contributor

RomeroMsk commented Mar 6, 2018

Check the code, please: https://github.com/bootstrap-vue/bootstrap-vue/blob/dev/src/components/modal/modal.js#L105-L138

It seems you mixed up the button variables: okButton uses t.cancelVariant, t.hide('cancel'), $slots['modal-cancel'], etc, and vise-versa.

@robcresswell

This comment has been minimized.

Contributor

robcresswell commented Mar 8, 2018

Ha, this is a weird one; although the variables are named wrong, it seems correctly rendered due to the parameters being swapped perfectly. We just need to rename the variables so it makes sense.

@RomeroMsk

This comment has been minimized.

Contributor

RomeroMsk commented Mar 8, 2018

We just need to rename the variables so it makes sense.

Yep. But maybe not to change the buttons order 😃 So it is like in BS4 examples: "Cancel / OK".

@RomeroMsk

This comment has been minimized.

Contributor

RomeroMsk commented Mar 12, 2018

Thank you.

@RomeroMsk

This comment has been minimized.

Contributor

RomeroMsk commented Mar 13, 2018

@robcresswell, could you please publish the updated version to NPM?

@robcresswell

This comment has been minimized.

Contributor

robcresswell commented Mar 13, 2018

I don't have that ability. Also there's a few other bugs to investigate before another tag, IMO.

@RomeroMsk

This comment has been minimized.

Contributor

RomeroMsk commented Mar 13, 2018

Ok, will wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment