New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing arrows in Form Select in v2.0.0-rc.2 #1658

Closed
x42y opened this Issue Mar 7, 2018 · 11 comments

Comments

Projects
None yet
6 participants
@x42y

x42y commented Mar 7, 2018

Version: 2.0.0-rc.2

As seen here: https://bootstrap-vue.js.org/docs/components/form-select/ the arrows in the select dropdowns are missing in rc 2.

@x42y x42y changed the title from Missing arrows in Form select in v2.0.0-rc.2 to Missing arrows in Form Select in v2.0.0-rc.2 Mar 7, 2018

@robcresswell

This comment has been minimized.

Contributor

robcresswell commented Mar 8, 2018

Ack, I think this is something I've changed. I'll take a look later today.

@robcresswell

This comment has been minimized.

Contributor

robcresswell commented Mar 8, 2018

Yeah, this is my fault, I've found the problem, fixing now.

robcresswell pushed a commit to robcresswell/bootstrap-vue that referenced this issue Mar 8, 2018

Rob Cresswell
fix(select): Fix custom/multiple/selectSize
The form-input component currently has some arbitary restrictions around
the combinations of multiple, custom-select and selectSize that will be
applied. Previously I tried to address this by passing through the
selectSize, but this caused an issue (hiding the arrows) in custom
selects when the size was set to 0.

This patch cleans up the internal computed state of form-select to be
more relaxed about what user input is rendered in the final component

Fixes: bootstrap-vue#1658
@ChrisCalculus

This comment has been minimized.

ChrisCalculus commented Mar 12, 2018

Hi @robcresswell, when will this be available in master? Thanks.

@robcresswell

This comment has been minimized.

Contributor

robcresswell commented Mar 12, 2018

@ChrisCalculus When I get time to finish it? In the next couple of days I'd imagine 😄

robcresswell pushed a commit to robcresswell/bootstrap-vue that referenced this issue Mar 12, 2018

Rob Cresswell
fix(select): Fix issues with form-select
The form-input component currently has some arbitary restrictions around
the combinations of multiple, custom-select and selectSize that will be
applied. Previously I tried to address this by passing through the
selectSize, but this caused an issue (hiding the arrows) in custom
selects when the size was set to 0.

This patch cleans up the internal computed state of form-select to be
more relaxed about what user input is rendered in the final component

Fixes: bootstrap-vue#1658
@robcresswell

This comment has been minimized.

Contributor

robcresswell commented Mar 12, 2018

That should fix a couple of issues with select. Sorry for breaking it, was fixing something else and derped.

@ChrisCalculus

This comment has been minimized.

ChrisCalculus commented Mar 13, 2018

Great @robcresswel, thanks for your time and solving it.

@Morgul

This comment has been minimized.

Morgul commented Mar 16, 2018

I'm currently getting hit by this as well, it's blocking upgrading to rc.2 for me.

@robcresswell

This comment has been minimized.

Contributor

robcresswell commented Mar 16, 2018

@Morgul: did you read the thread?

@Morgul

This comment has been minimized.

Morgul commented Mar 16, 2018

@robcresswell Yes, I did, I'm aware of the open merge request. But it's often useful to know how many people are effected by an issue when planning releases, etc, and my comment was just an attempt to provide that. :)

@pi0 pi0 closed this in #1673 Mar 31, 2018

pi0 added a commit that referenced this issue Mar 31, 2018

fix(select): Fix issues with form-select (#1673)
The form-input component currently has some arbitary restrictions around
the combinations of multiple, custom-select and selectSize that will be
applied. Previously I tried to address this by passing through the
selectSize, but this caused an issue (hiding the arrows) in custom
selects when the size was set to 0.

This patch cleans up the internal computed state of form-select to be
more relaxed about what user input is rendered in the final component

Fixes: #1658

dannycjones added a commit to dannycjones/algorepo that referenced this issue Apr 1, 2018

@iruizeguilaz

This comment has been minimized.

iruizeguilaz commented Apr 10, 2018

I have updated the version and getiing these missing arrows in Form Select back, but someone else has come acrross a similar problem with the table columns in sorting??? I do not get the arrows there....

@Jodge

This comment has been minimized.

Jodge commented May 6, 2018

I am currently experiencing the same problem on "vue": "^2.5.2"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment