New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

b-card footer and header template slots not working #1680

Closed
ChrisCalculus opened this Issue Mar 14, 2018 · 13 comments

Comments

Projects
None yet
8 participants
@ChrisCalculus

ChrisCalculus commented Mar 14, 2018

First of, thanks for all your hard work and time.

The b-card footer (and header) template slot appears to have stopped working in v2.0.0-rc.2.

<b-card>
  <strong slot="header">Some header content</strong>
  <b-row>Some content</b-row>
  <em slot="footer">Some footer content</em>
</b-card>

The header and footer content are not displayed (where they previously did).

  • Operating system and version: Mac High Sierra
  • Browser and version: Chrome Version 65.0.3325.162 (Official Build) (64-bit)
  • Version of Bootstrap-Vue that you are using: v2.0.0-rc.2
  • Reduced test cases: https://jsfiddle.net/h1h9g4h2/
@samcgarry

This comment has been minimized.

samcgarry commented Mar 15, 2018

I've seen something similar on v1.5.1 but it seems related to a change between Vue JS 2.5.15 and 2.5.16. If I revert back to the older version the card slots render fine.

@ChrisCalculus

This comment has been minimized.

ChrisCalculus commented Mar 15, 2018

@samcgarry interesting. In the 2.5.16 release notes two bug fixes mention slots:

  • fix wrongly matched named slots in functional components 62a922e, closes #7817
  • named slots for nested functional components 6dd73e9, closes #7710

Hopefully this helps in debugging.

@repetier

This comment has been minimized.

repetier commented Mar 15, 2018

Strange bug. Had it with v2.0.0-rc2 and vue 2.5.2. Upgrade to vue 2.5.16 did not help, but going back to 2.5.15 seemed to do the trick for me.

@robcresswell

This comment has been minimized.

Contributor

robcresswell commented Mar 16, 2018

"latest from npm install" - could you give us an actual version? This is completely dependent on what is specified in your package.json. I'm assuming its 2.0.0-rc2, but it'd be really helpful if you could specify the version; it's also handy for others looking at issues in the future 😇

@samcgarry

This comment has been minimized.

samcgarry commented Mar 16, 2018

I updated my bootstrap-vue to 2.0.0-rc2 and reproduced the same issue by moving from vue 2.5.15 and 2.5.16. I suspect it is probably related to the two issues in the 2.5.16 release notes that @ChrisCalculus mentioned.

@ChrisCalculus

This comment has been minimized.

ChrisCalculus commented Mar 16, 2018

Hi @robcresswell, sorry yes I mentioned the version in the second line: it's v2.0.0-rc.2 indeed.

@robcresswell

This comment has been minimized.

Contributor

robcresswell commented Mar 16, 2018

Ah you're right, my mistake. I'll do some investigation into this later today.

@mjl

This comment has been minimized.

mjl commented Mar 18, 2018

I can confirm that it is related to vue 2.5.16; backing down to 2.5.15 makes the slots reappear with no other changes anywhere.

@lmapii

This comment has been minimized.

lmapii commented Mar 21, 2018

having the same problem here, downgrading to 2.5.15 works.

@pi0

This comment has been minimized.

Member

pi0 commented Apr 2, 2018

2.5.16 problem fixed with rc.5.

@pi0 pi0 closed this Apr 2, 2018

@FrancescoMussi

This comment has been minimized.

FrancescoMussi commented Aug 29, 2018

I have Vue version 2.5.17 and I have the same problem.
Any suggestion?

bootstrap-vue version: 1.5.1

Thanks

@robcresswell

This comment has been minimized.

Contributor

robcresswell commented Aug 29, 2018

@FrancescoMussi If you read the comment above your it says it was fixed with 2.0.0-rc.5

@FrancescoMussi

This comment has been minimized.

FrancescoMussi commented Aug 29, 2018

Thanks @robcresswell for fast reply!

I misunderstood that comment from @pi0 , since it was referring to Vue version I didn't get the solution was with boostrap-vue 2.0.0-rc.5.

Thanks for clarification.
I have installed boostrap-vue 2.0.0-rc.5 and now the slot header is working correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment