Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Component] Datepicker #3676

Closed

Comments

@rbqdev
Copy link

@rbqdev rbqdev commented Jul 11, 2019

Describe the solution you'd like

Would be great to DatePicker component. Usually always need to use third libs or create own for work with Dates on bootstrap.

What you think about it? Do you already have that kind of component in mind?

@rbqdev rbqdev changed the title [Component]Datepicker [Component] Datepicker Jul 11, 2019
@tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Jul 11, 2019

We've thought about it (and I have a rudimentary one built using BootstrapVue components and classes), but we may release these "etrxa" components in a companion library to keep this library bundle size smaller.

Datepickers tend to get large/complex with requirement for formatting dates, optional timepickers, restrictions (ranges, disabled, dates, start-end dates, etc), and not to mention internationalization (i18n), making them quite large bundle size.

@jevgenigavrilov
Copy link

@jevgenigavrilov jevgenigavrilov commented Jul 11, 2019

@tmorehouse defo will be looking forward for this. You mentioned "components", wondering what the others are?

@rbqdev
Copy link
Author

@rbqdev rbqdev commented Jul 11, 2019

@tmorehouse Thanks for the detailed explanation.

@tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Jul 11, 2019

Thinking of creating: BootstrapVueExtras:

  • Datepicker (looks similar in style to the android datepicker, based on modal)
  • Tags input
  • Responsive constrained aspect container (i.e. provide aspect ratio like 16:9, 4:3, plus arbitrary contstraints), as an alternative to b-embed which only works for objects, embed, iframe)
  • An "in-view" directive (like v-if, but only renders the element when the parent scrolls into view, using intersection observer)
  • Loader (like spinners, but with the appearance of progress bar)
  • A custom select based on b-dropdown (which allows styling of the options, unlike native select)
  • Avatar component, based on b-badge

@patrickblackjr
Copy link
Contributor

@patrickblackjr patrickblackjr commented Jul 13, 2019

I like the idea of having them seperate

@tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Jul 13, 2019

Some of these might be small enough that they could be included in BootstrapVue, but definitely the date picker will be separate

@tmorehouse tmorehouse added this to To do in 2.4.2 via automation Feb 1, 2020
@tmorehouse tmorehouse moved this from To do to In progress in 2.4.2 Feb 3, 2020
@jacobmllr95 jacobmllr95 removed this from In progress in 2.4.2 Feb 14, 2020
@jacobmllr95 jacobmllr95 added this to To do in 2.5.0 via automation Feb 14, 2020
2.5.0 automation moved this from To do to Done Feb 16, 2020
tmorehouse added a commit that referenced this issue Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment