Skip to content

wrap not configurable in carousel #3902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
geocode64 opened this issue Aug 16, 2019 · 0 comments · Fixed by #3905, mariazevedo88/hash-generator-js#4 or tghelere/CL#8
Closed

wrap not configurable in carousel #3902

geocode64 opened this issue Aug 16, 2019 · 0 comments · Fixed by #3905, mariazevedo88/hash-generator-js#4 or tghelere/CL#8
Labels
Priority: Medium Type: Feature request

Comments

@geocode64
Copy link

Describe the bug
The option to stop the carousel from cyling back to the begining is not available: See the wrap option here https://getbootstrap.com/docs/4.0/components/carousel/#options

Expected behavior
A "no-wrap" or similar directive should be available on the b-carousel component
tmorehouse added a commit that referenced this issue Aug 16, 2019
@tmorehouse
feat(b-carousel): add prop no-wrap for disabling wrapping to start/…
942f963 
…end (closes #3902)
@tmorehouse tmorehouse mentioned this issue Aug 16, 2019
Merged
19 tasks
jacobmllr95 pushed a commit that referenced this issue Aug 17, 2019
@tmorehouse @jacobmllr95
feat(b-carousel): add prop no-wrap for disabling wrapping to start/…
2c8bd23 
…end (closes #3902) (#3905)

* feat(b-carousel): add prop `no-wrap` for disabling wrapping to start/end (closes #3902)

* Update carousel.js

* Update carousel.js

* Update carousel.spec.js

* Update carousel.spec.js

* Update carousel.spec.js

* Update README.md

* Update README.md

* Update index.d.ts

* Update README.md

* Update carousel.js
@snyk-bot snyk-bot mentioned this issue Sep 15, 2019
Closed
@snyk-bot snyk-bot mentioned this issue Sep 22, 2019
Merged
@snyk-bot snyk-bot mentioned this issue Oct 1, 2019
Closed
@snyk-bot snyk-bot mentioned this issue Jan 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Medium Type: Feature request
Projects
None yet
Milestone
No milestone
2 participants
@geocode64 @tmorehouse