Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrap not configurable in carousel #3902

Closed
geocode64 opened this issue Aug 16, 2019 · 0 comments · Fixed by #3905 · May be fixed by thislooksfun/earthdawn#37

Comments

@geocode64
Copy link

commented Aug 16, 2019

Describe the bug
The option to stop the carousel from cyling back to the begining is not available: See the wrap option here https://getbootstrap.com/docs/4.0/components/carousel/#options

Expected behavior
A "no-wrap" or similar directive should be available on the b-carousel component

tmorehouse added a commit that referenced this issue Aug 16, 2019

@jackmu95 jackmu95 added this to Completed in 2.0.0 Stable via automation Aug 17, 2019

jackmu95 added a commit that referenced this issue Aug 17, 2019
feat(b-carousel): add prop `no-wrap` for disabling wrapping to start/…
…end (closes #3902) (#3905)

* feat(b-carousel): add prop `no-wrap` for disabling wrapping to start/end (closes #3902)

* Update carousel.js

* Update carousel.js

* Update carousel.spec.js

* Update carousel.spec.js

* Update carousel.spec.js

* Update README.md

* Update README.md

* Update index.d.ts

* Update README.md

* Update carousel.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.