Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden `b-form-textarea` not auto-sizing when becoming visible #3936

Closed
tradingstratagem opened this issue Aug 23, 2019 · 3 comments · Fixed by #3937 · May be fixed by thislooksfun/earthdawn#37

Comments

@tradingstratagem
Copy link

commented Aug 23, 2019

Describe the bug

When a textarea is initially hidden it isn't rendered correctly.
The rows property is not taken into account, so the textarea is very small.

Steps to reproduce the bug

  1. Put a b-form-textarea inside a modal
  2. Open the modal
  3. The textarea has not the correct height
  4. Type in something and it automatically adjust its height

Expected behavior

The textarea should have the correct height from the beginning

Before
before

After typing in a character
after

Versions

Libraries:

  • BootstrapVue: 2.0.0-rc.28
  • Bootstrap: 4.3.1
  • Vue: 2.6.10

Environment:

  • Device: Mac
  • OS: macOS Mojave
  • Browser: Chrome
  • Version: 76
tmorehouse added a commit that referenced this issue Aug 23, 2019
fix(b-form-textarea): handle initial auto height when in modal or oth…
…er component with transition delays (closes #3936)

@tmorehouse tmorehouse changed the title Hidden b-form-textarea Hidden `b-form-textarea` not auto-sizing when becoming viable Aug 24, 2019

@tmorehouse

This comment has been minimized.

Copy link
Member

commented Aug 24, 2019

PR #3937 should have this fixed (once it is merged into 2.0.0 stable branch)

@tradingstratagem

This comment has been minimized.

Copy link
Author

commented Aug 24, 2019

Thank you

@tmorehouse tmorehouse changed the title Hidden `b-form-textarea` not auto-sizing when becoming viable Hidden `b-form-textarea` not auto-sizing when becoming visible Aug 24, 2019

tmorehouse added a commit that referenced this issue Aug 26, 2019
fix(b-form-textarea): handle initial auto-height when in modal, tabs,…
… or other component with transition or which uses `v-show` (fixes #3936, #3702) (#3937)
@tmorehouse

This comment has been minimized.

Copy link
Member

commented Sep 7, 2019

BootstrapVue v2.0.0 stable has been released. See https://bootstrap-vue.js.org/docs/misc/changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.