Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hidden b-form-textarea not auto-sizing when becoming visible #3936

Closed
tradingstratagem opened this issue Aug 23, 2019 · 3 comments · Fixed by #3937, mariazevedo88/hash-generator-js#4 or tghelere/CL#8
Closed

Hidden b-form-textarea not auto-sizing when becoming visible #3936

tradingstratagem opened this issue Aug 23, 2019 · 3 comments · Fixed by #3937, mariazevedo88/hash-generator-js#4 or tghelere/CL#8
Labels
Type: Bug Type: Enhancement

Comments

@tradingstratagem
Copy link

Describe the bug

When a textarea is initially hidden it isn't rendered correctly.
The rows property is not taken into account, so the textarea is very small.

Steps to reproduce the bug

  1. Put a b-form-textarea inside a modal
  2. Open the modal
  3. The textarea has not the correct height
  4. Type in something and it automatically adjust its height

Expected behavior

The textarea should have the correct height from the beginning

Before
before

After typing in a character
after

Versions

Libraries:

  • BootstrapVue: 2.0.0-rc.28
  • Bootstrap: 4.3.1
  • Vue: 2.6.10

Environment:

  • Device: Mac
  • OS: macOS Mojave
  • Browser: Chrome
  • Version: 76
tmorehouse added a commit that referenced this issue Aug 23, 2019
@tmorehouse
fix(b-form-textarea): handle initial auto height when in modal or oth…
1829ea7 
…er component with transition delays (closes #3936)
@tmorehouse tmorehouse mentioned this issue Aug 23, 2019
Merged
19 tasks
@tmorehouse tmorehouse changed the title Hidden b-form-textarea Hidden b-form-textarea not auto-sizing when becoming viable Aug 24, 2019
@tmorehouse
Copy link
Member

PR #3937 should have this fixed (once it is merged into 2.0.0 stable branch)

@tradingstratagem
Copy link
Author

Thank you

@tmorehouse tmorehouse changed the title Hidden b-form-textarea not auto-sizing when becoming viable Hidden b-form-textarea not auto-sizing when becoming visible Aug 24, 2019
tmorehouse added a commit that referenced this issue Aug 26, 2019
@tmorehouse
fix(b-form-textarea): handle initial auto-height when in modal, tabs,…
be3ac62 
… or other component with transition or which uses `v-show` (fixes #3936, #3702) (#3937)
@tmorehouse
Copy link
Member

BootstrapVue v2.0.0 stable has been released. See https://bootstrap-vue.js.org/docs/misc/changelog

@snyk-bot snyk-bot mentioned this issue Sep 15, 2019
Closed
@snyk-bot snyk-bot mentioned this issue Sep 22, 2019
Merged
@snyk-bot snyk-bot mentioned this issue Oct 1, 2019
Closed
@snyk-bot snyk-bot mentioned this issue Jan 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Type: Enhancement
Projects
None yet
Milestone
No milestone
2 participants
@tmorehouse @tradingstratagem