Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<b-media> has wrong vertical align class #4052

Closed
Jexordexan opened this issue Sep 9, 2019 · 3 comments · Fixed by #4055, mariazevedo88/hash-generator-js#4 or mariazevedo88/hash-generator-js#11

Comments

@Jexordexan
Copy link

commented Sep 9, 2019

Describe the bug

The b-media components "aside" slot has a default vertical align class of align-self-top which does not exist in bootstrap CSS. I believe align-self-start is what was meant.

Steps to reproduce the bug

  1. Go to https://bootstrap-vue.js.org/docs/components/media#vertical-align
  2. It says possible values are top, center and end, with top as default.
  3. top maps to using the align-self-top class which has no styles

Expected behavior

Replace top with start in docs and code.

Versions

Libraries:

  • BootstrapVue: 2.0
  • Bootstrap: 4.3
  • Vue: 2.6

Environment:

N/A

@tmorehouse tmorehouse added the Type: Bug label Sep 9, 2019
tmorehouse added a commit that referenced this issue Sep 9, 2019
…ixes #4052)
@tmorehouse

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

Will be fixed in the 2.0.1 release.

In the meantime, you can switch to use end and start on the vertical-align prop

@jackmu95 jackmu95 changed the title BMedia has wrong vertical align class. <b-media> has wrong vertical align class. Sep 9, 2019
@jackmu95 jackmu95 changed the title <b-media> has wrong vertical align class. <b-media> has wrong vertical align class Sep 9, 2019
jackmu95 added a commit that referenced this issue Sep 9, 2019
…ixes #4052) (#4055)

* fix(b-media): fix vertical align class when top or bottom selected (fixes #4052)

* Update media-aside.js

* Update media.spec.js

* Update media-aside.spec.js
@Jexordexan

This comment has been minimized.

Copy link
Author

commented Sep 9, 2019

Awesome! thanks for the quick fix 👍

@tmorehouse

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

Will be available in 2.0.1 patch release....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.