Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using v-b-tooltip without setting a title shows empty tooltip #4064

Closed
FabianAlbrecht opened this issue Sep 10, 2019 · 4 comments · Fixed by #4076, mariazevedo88/hash-generator-js#4 or mariazevedo88/hash-generator-js#11

Comments

@FabianAlbrecht
Copy link

commented Sep 10, 2019

Describe the bug

If you add a v-b tooltip to an element without setting a title, an empty tooltip is displayed above the element. I think in earlier versions, the tooltip was hidden until the title was set.

Example:
image

Steps to reproduce the bug

Create a button with an empty tooltip:
<b-button v-b-tooltip>Test</b-button>
or
<b-button v-b-tooltip="undefined">Test</b-button>
or
<b-button v-b-tooltip="null">Test</b-button>

Expected behavior

The tooltip is only displayed if a title has been set

Versions

Libraries:

  • BootstrapVue: 2.0.0
  • Bootstrap: 4.3.1
  • Vue: 2.6.10

Environment:

  • Device: Mac
  • OS: macOS Mojave
  • Browser: Chrome
  • Version: 76
@tmorehouse

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

This is new expected behaviour with the new implementation code for popovers and tooltips. Tooltips and popovers will show even without content.

v2.0.1 will have the disabled property for directive versions (it was missing in the 2.0.0 release).

If you do not want a tooltip to be shown, then you will need to set disabled on the tooltip/popover, or change the trigger to manual, which will disable any other triggers.

@FabianAlbrecht

This comment has been minimized.

Copy link
Author

commented Sep 11, 2019

Ok i will try this solution when v2.0.1 is out although I'd like it better if it would show no tooltip instead of an empty one when there is no title. Doesn't make much sense to me to have an empty tooltip here. But probably you can decide that better because of your knowledge of the code.

tmorehouse added a commit that referenced this issue Sep 11, 2019
closes #4064)
@tmorehouse

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

I think we have a solution for the directive versions.

@tmorehouse

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

A fix will be available in release v2.0.1 coming later this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.