Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

b-tabs with prop no-key-nav Jaws support #4323

Closed
ghost opened this issue Oct 30, 2019 · 4 comments · Fixed by #4326, mariazevedo88/hash-generator-js#17, CloudsdaleGroup/AnimFM#3, mariazevedo88/hash-generator-js#24 or tghelere/CL#8
Closed

b-tabs with prop no-key-nav Jaws support #4323

ghost opened this issue Oct 30, 2019 · 4 comments · Fixed by #4326, mariazevedo88/hash-generator-js#17, CloudsdaleGroup/AnimFM#3, mariazevedo88/hash-generator-js#24 or tghelere/CL#8
Assignees
@tmorehouse
Labels
Type: Accessibility

Comments

@ghost
Copy link

ghost commented Oct 30, 2019

When using Jaws Screen reader, a focused tab is announced as "to activate tab page press SPACEBAR" but the supported key to activate the current focused tab in the component is "ENTER" instead.
The b-tabs component should support "SPACEBAR" to select a focused tab.
@tmorehouse
Copy link
Member

Hmmm... I thought we had added SPACE as well as ENTER.

We will need to add this in.

@tmorehouse tmorehouse self-assigned this Oct 30, 2019
@tmorehouse
Copy link
Member

@fabo15x is this only when no-key-nav is set? or does it happen with key nav is enabled as well?

@tmorehouse
Copy link
Member

Looking a the code, it appears that the issue was with no-key-nav enabled.

tmorehouse added a commit that referenced this issue Oct 30, 2019
@tmorehouse
fix(b-tabs): allow space to trigger tab activation when no-key-nav …
ee5b236 
…is enabled (fixes #4323)
@tmorehouse tmorehouse mentioned this issue Oct 30, 2019
Merged
19 tasks
tmorehouse added a commit that referenced this issue Oct 30, 2019
@tmorehouse
fix(b-tabs): allow space to trigger tab activation when no-key-nav …
731365b 
…is enabled (fixes #4323) (#4326)
@tmorehouse tmorehouse mentioned this issue Oct 30, 2019
Merged
@tmorehouse
Copy link
Member

BootstrapVue v2.1.0 has been released, which has a fix for this issue.

@snyk-bot snyk-bot mentioned this issue Nov 21, 2019
Merged
@snyk-bot snyk-bot mentioned this issue Dec 12, 2019
Merged
This was referenced Jan 17, 2020
Merged
Merged
@snyk-bot snyk-bot mentioned this issue Feb 25, 2020
Closed
@snyk-bot snyk-bot mentioned this issue Mar 4, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmorehouse tmorehouse

Labels
Type: Accessibility
Projects
None yet
Milestone
No milestone
2 participants
@jacobmllr95 @tmorehouse