Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip memory leaks #4400

Closed
horvayev opened this issue Nov 19, 2019 · 6 comments · Fixed by #4401 or mariazevedo88/hash-generator-js#24 · May be fixed by tghelere/CL#8
Closed

Tooltip memory leaks #4400

horvayev opened this issue Nov 19, 2019 · 6 comments · Fixed by #4401 or mariazevedo88/hash-generator-js#24 · May be fixed by tghelere/CL#8

Comments

@horvayev
Copy link

@horvayev horvayev commented Nov 19, 2019

Describe the bug

Hi, I have found a memory leak caused by tooltip directive.

Steps to reproduce the bug

  1. Create buttons with tooltip directive
  2. Delete buttons from DOM
  3. Take snapshot - detached HtmlInputElement and others remain in memory

Bug is probably in

this.visibleInterval = setInterval(() => {

Versions

Libraries:

  • BootstrapVue: 2.0.4
  • Vue: 2.6.10

Demo link

CodeSandbox

mem_prof

I would appreciate if you could take a look, as we heavily use tooltips and popovers in our production app.

Thank you.

@jackmu95

This comment has been minimized.

Copy link
Member

@jackmu95 jackmu95 commented Nov 19, 2019

@horvayev Can you please try to recreate your CodeSandbox in the Playground of the deployment preview and confirm that the memory leak is fixed?
https://5dd39f9c82c27d000c4e3c57--bootstrap-vue.netlify.com/play

@horvayev

This comment has been minimized.

Copy link
Author

@horvayev horvayev commented Nov 19, 2019

Thank you, memory leak seems to be resolved. When do you expect new version to be released?

@jackmu95

This comment has been minimized.

Copy link
Member

@jackmu95 jackmu95 commented Nov 19, 2019

@horvayev Have to talk with @tmorehouse about ist but I think at the least by the end of the week.

jackmu95 added a commit that referenced this issue Nov 20, 2019
* fix(v-b-tooltip): memory leaks

* Update bv-tooltip.js

* Update bv-tooltip.js

* Update bv-tooltip.js

* Update bv-tooltip.js

* Update bv-tooltip.js

* Update bv-tooltip.js
@kebus01

This comment has been minimized.

Copy link

@kebus01 kebus01 commented Jan 6, 2020

Hi, when do you expect to release new version with this fix? We would really appreciate if the patch came out as soon as possible because the memory leak causes great inconvenience in our production app.

@jackmu95

This comment has been minimized.

Copy link
Member

@jackmu95 jackmu95 commented Jan 7, 2020

@kebus01 We hope to have v2.2.0 out by the end of the week!

@tmorehouse

This comment has been minimized.

Copy link
Member

@tmorehouse tmorehouse commented Jan 9, 2020

BootstrapVue v2.2.0 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.