Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: configure pre-commit hook for better DX #4532

Closed
jamesgeorge007 opened this issue Dec 25, 2019 · 2 comments · Fixed by #4552 or mariazevedo88/hash-generator-js#24 · May be fixed by tghelere/CL#8
Closed

[chore]: configure pre-commit hook for better DX #4532

jamesgeorge007 opened this issue Dec 25, 2019 · 2 comments · Fixed by #4552 or mariazevedo88/hash-generator-js#24 · May be fixed by tghelere/CL#8

Comments

@jamesgeorge007
Copy link
Contributor

@jamesgeorge007 jamesgeorge007 commented Dec 25, 2019

pre-commit hooks can come in handy while in the Dev workflow. The lint script can be made to execute automatically before making a commit (and staging updated files).

@jamesgeorge007

This comment has been minimized.

Copy link
Contributor Author

@jamesgeorge007 jamesgeorge007 commented Dec 25, 2019

I would be happy to shoot a PR on receiving a green signal 👍

@jackmu95

This comment has been minimized.

Copy link
Member

@jackmu95 jackmu95 commented Jan 3, 2020

I would be fine with that if it doesn't effect the speed of commiting to much.
We need to make sure only relevant files are linted/prettified.

@jamesgeorge007 PR's are always welcome :)

jackmu95 added a commit that referenced this issue Jan 7, 2020
* chore: add husky and lint-staged as devDeps

* feat: configure pre-commit hook

* chore: update lock file

Co-authored-by: Jacob Müller <jacob.mueller.elz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.