Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: configure pre-commit hook for better DX #4532

Closed

Comments

@jamesgeorge007
Copy link
Contributor

@jamesgeorge007 jamesgeorge007 commented Dec 25, 2019

pre-commit hooks can come in handy while in the Dev workflow. The lint script can be made to execute automatically before making a commit (and staging updated files).

@jamesgeorge007
Copy link
Contributor Author

@jamesgeorge007 jamesgeorge007 commented Dec 25, 2019

I would be happy to shoot a PR on receiving a green signal 👍

@jacobmllr95
Copy link
Member

@jacobmllr95 jacobmllr95 commented Jan 3, 2020

I would be fine with that if it doesn't effect the speed of commiting to much.
We need to make sure only relevant files are linted/prettified.

@jamesgeorge007 PR's are always welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment