Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icon transform features do not work on IE11 #4607

Closed
tmorehouse opened this issue Jan 12, 2020 · 2 comments · Fixed by #4608, tghelere/CL#10, mariazevedo88/hash-generator-js#26, tghelere/CL#11 or mariazevedo88/hash-generator-js#28
Closed

icon transform features do not work on IE11 #4607

tmorehouse opened this issue Jan 12, 2020 · 2 comments · Fixed by #4608, tghelere/CL#10, mariazevedo88/hash-generator-js#26, tghelere/CL#11 or mariazevedo88/hash-generator-js#28
Assignees
@tmorehouse
Labels
Status: Browser Bug Status: Fixed / Implemented Issue fixed by a new release

Comments

@tmorehouse
Copy link
Member

Describe the bug

Icon transform features do not work on IE11 (flipping, rotate, scale, shifting)

Steps to reproduce the bug

Open icon docs in IE11 browser

Versions

Libraries:

  • BootstrapVue: 2.2.0
  • Bootstrap: 4.4.1
  • Vue: 2.6.11

Environment:

  • Device: PC
  • OS: Windows 7
  • Browser: IE11

Additional context

IE11 will only apply transforms to the outer <svg> element, not the inner <g> element

May need to detect IE11 and apply the transform styles to the root svg element, possibly wrapping the icons in an inline block element so that additional user transforms can be applied, or change to use the transform attribute on the svg root element
@tmorehouse tmorehouse self-assigned this Jan 12, 2020
@tmorehouse
Copy link
Member Author

Switching to transform attribute on the <g> element works well with IE11 (and all other browsers).

tmorehouse added a commit that referenced this issue Jan 12, 2020
@tmorehouse
fix(icons): make icon transforms work with IE11 (closes #4607)
11b2c50
@tmorehouse tmorehouse mentioned this issue Jan 12, 2020
Merged
20 tasks
@tmorehouse tmorehouse mentioned this issue Jan 12, 2020
Merged
tmorehouse added a commit that referenced this issue Jan 12, 2020
@tmorehouse
fix(icons): make icon transform props work with IE11 (closes #4607) (#…
899779f 
…4608)
@tmorehouse
Copy link
Member Author

v2.2.1 has been released.

This was referenced Feb 5, 2020
Merged
Merged
Merged
Merged
@snyk-bot snyk-bot mentioned this issue Feb 25, 2020
Closed
@snyk-bot snyk-bot mentioned this issue Mar 4, 2020
Open
@tmorehouse tmorehouse added the Status: Fixed / Implemented Issue fixed by a new release label May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmorehouse tmorehouse

Labels
Status: Browser Bug Status: Fixed / Implemented Issue fixed by a new release
Projects
None yet
Milestone
No milestone
1 participant
@tmorehouse