Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(b-tab): add ability to specify button attributes #4803

Comments

@andrewvasilchuk
Copy link
Contributor

@andrewvasilchuk andrewvasilchuk commented Feb 20, 2020

Is your feature request related to a problem? Please describe...

Somehow I need to set custom attributes to button, but all I have found is that we can pass only button-id prop.

Describe the solution you'd like

The solution is to provide button-attributes prop, that will be merged with aria-attributes provided by framework itself. BUT framework generated aria-attributes should take precedence.

Example of possible solution:

<b-tab :button-attributes="{ 'data-t-foo': 'bar' }">...</b-tab>
@andrewvasilchuk
Copy link
Contributor Author

@andrewvasilchuk andrewvasilchuk commented Feb 20, 2020

@jackmu95, Can I start an implementation?

tmorehouse added a commit that referenced this issue Feb 23, 2020
…oses: #4803) (#4806)

Co-authored-by: Jacob Müller <jacob.mueller.elz@gmail.com>
Co-authored-by: Troy Morehouse <troymore@nbnet.nb.ca>
@tmorehouse tmorehouse added the Status: Fixed / Implemented label May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment