Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(b-tab): add ability to specify button attributes #4803

Closed
andrewvasilchuk opened this issue Feb 20, 2020 · 1 comment · Fixed by #4806, tghelere/CL#18, mariazevedo88/hash-generator-js#39, mariazevedo88/hash-generator-js#40 or tghelere/CL#20
Closed

feat(b-tab): add ability to specify button attributes #4803

andrewvasilchuk opened this issue Feb 20, 2020 · 1 comment · Fixed by #4806, tghelere/CL#18, mariazevedo88/hash-generator-js#39, mariazevedo88/hash-generator-js#40 or tghelere/CL#20
Labels
Priority: Low Status: Fixed / Implemented Issue fixed by a new release Type: Feature request

Comments

@andrewvasilchuk
Copy link
Contributor

Is your feature request related to a problem? Please describe...

Somehow I need to set custom attributes to button, but all I have found is that we can pass only button-id prop.

Describe the solution you'd like

The solution is to provide button-attributes prop, that will be merged with aria-attributes provided by framework itself. BUT framework generated aria-attributes should take precedence.

Example of possible solution:

<b-tab :button-attributes="{ 'data-t-foo': 'bar' }">...</b-tab>
@andrewvasilchuk
Copy link
Contributor Author

@jackmu95, Can I start an implementation?

@andrewvasilchuk andrewvasilchuk mentioned this issue Feb 20, 2020
Merged
20 tasks
@tmorehouse tmorehouse mentioned this issue Feb 23, 2020
Merged
tmorehouse added a commit that referenced this issue Feb 23, 2020
@andrewvasilchuk @jacobmllr95 @tmorehouse
feat(b-tabs): add ability to provide custom tab button attributes (cl…
c541d3d 
…oses: #4803) (#4806)

Co-authored-by: Jacob Müller <jacob.mueller.elz@gmail.com>
Co-authored-by: Troy Morehouse <troymore@nbnet.nb.ca>
This was referenced Mar 27, 2020
Merged
Merged
Merged
Merged
@snyk-bot snyk-bot mentioned this issue Apr 7, 2020
Open
This was referenced Apr 15, 2020
Open
Open
@snyk-bot snyk-bot mentioned this issue Apr 30, 2020
Open
@tmorehouse tmorehouse added the Status: Fixed / Implemented Issue fixed by a new release label May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Low Status: Fixed / Implemented Issue fixed by a new release Type: Feature request
Projects
None yet
Milestone
No milestone
3 participants
@jacobmllr95 @tmorehouse @andrewvasilchuk