Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

b-pagination config #4811

Closed
Labels

Comments

@AmazingMoon
Copy link

@AmazingMoon AmazingMoon commented Feb 21, 2020

I have a small suggestion, can page-link render into non-a tags?
Provide a configurable property, render as div.page-link, etc.
This is to solve the SEO problem of Link anchor text is trivial.

@tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Feb 21, 2020

Accessibility wise, it would need to stay as an <a> tag for <b-pagination-nav>, but for <b-pagination> we might be able to switch to <button> (it is best to use semantic HTM5 elements where possible to preserve proper roles for a11y rather trying to replicate roles and behaviours on non-interactive elements), assuming that Bootstrap's SCSS/CSS can handle styling the buttons correctly.

Using <a> is Bootstrap v4's recommended structure, but we would be willing to look into switching the <a> for button's in <b-pagination>

@tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Feb 21, 2020

<b-pagination> renders as an ARIA menuitemradio bar (the page numbers have role menuitemradio), so it sounds like the SEO tool you are using doesn't take accessibility into account when looking at the markup.

@AmazingMoon
Copy link
Author

@AmazingMoon AmazingMoon commented Feb 21, 2020

@tmorehouse Yes! So I want to avoid this problem.

tmorehouse added a commit that referenced this issue Feb 23, 2020
: #4811, #4160) (#4810)

Co-authored-by: Jacob Müller <jacob.mueller.elz@gmail.com>
@tmorehouse tmorehouse added the Status: Fixed / Implemented label May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment