Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form Datepicker in Modal #4814

Closed
Assignees

Comments

@iarturovich
Copy link

@iarturovich iarturovich commented Feb 24, 2020

The buttons for moving to the next month in the modal window do not work

@Hiws
Copy link
Member

@Hiws Hiws commented Feb 24, 2020

They appear to be working for me in Chrome.
https://codepen.io/Hiws/pen/JjdEXOZ

Which browser are you using?

@iarturovich
Copy link
Author

@iarturovich iarturovich commented Feb 24, 2020

Firefox

@iarturovich
Copy link
Author

@iarturovich iarturovich commented Feb 24, 2020

In firefox do not work also https://codepen.io/Hiws/pen/JjdEXOZ

@Hiws
Copy link
Member

@Hiws Hiws commented Feb 24, 2020

Just tested it on Firefox 73 and the buttons appear to be working fine here as well.

Which version are you on, and what OS?

@iarturovich
Copy link
Author

@iarturovich iarturovich commented Feb 24, 2020

Firefox Developer Edition version is 74.0
Operating System: Mac OS (10.15) | Browser Engine: Gecko (74.0)
In chrome works, but on firefox no

@Hiws
Copy link
Member

@Hiws Hiws commented Feb 24, 2020

Tested it in Firefox Developer Edition 74.0b7 on windows and looks to be working.

This might be a MacOS related issue, which i sadly can't test.

Is this something you could test? @jackmu95

@iarturovich
Copy link
Author

@iarturovich iarturovich commented Feb 24, 2020

Checked on windows and everything works. So it doesn't work on Mac OS

@jacobmllr95 jacobmllr95 self-assigned this Feb 24, 2020
@jacobmllr95 jacobmllr95 added this to To do in 2.6.0 via automation Feb 24, 2020
@jacobmllr95
Copy link
Member

@jacobmllr95 jacobmllr95 commented Feb 24, 2020

@Hiws I can confirm that it closes the modal on Firefox and safari on MacOS.
I will look into this soon.

@tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Feb 24, 2020

@jackmu95 This might be due to clicking on an inner element within the button (i.e. the SVG).

Perhaps we should switch the 'click' event listener to '!click' (capture mode) for the month navigation buttons.

@jacobmllr95
Copy link
Member

@jacobmllr95 jacobmllr95 commented Feb 24, 2020

@tmorehouse Yeah, that was my first idea. Will try it soon.

@tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Feb 24, 2020

I wonder if the b-form-spinbutton's + and - buttons have the same symptom.

@tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Feb 24, 2020

Also, try checking on the dev docs, and PR #4783 deploye preview docs to see if the symptom still persists.

2.6.0 automation moved this from To do to Done Feb 25, 2020
jacobmllr95 added a commit that referenced this issue Feb 25, 2020
… MacOS (closes #4814) (#4824)

* fix(b-calendar): wrapper focus handling

* Move tabindex to menu
@tmorehouse tmorehouse added the Status: Fixed / Implemented label May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment